You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by smarthi <gi...@git.apache.org> on 2016/07/23 06:02:29 UTC

[GitHub] incubator-pirk pull request #20: Pirk 11: Switch to SLF4J with Log4j2 bindin...

GitHub user smarthi opened a pull request:

    https://github.com/apache/incubator-pirk/pull/20

    Pirk 11: Switch to SLF4J with Log4j2 bindings

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/incubator-pirk PIRK-11

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
    
----
commit 37c45702460f9f11f1af0faabf0e4d3576873cc7
Author: smarthi <sm...@apache.org>
Date:   2016-07-22T20:34:18Z

    PIRK-10: Upgrade and Enforce Java 8

commit 76e4bf374f3131a73b43fcdccf0850da05976f6d
Author: smarthi <sm...@apache.org>
Date:   2016-07-23T06:01:12Z

    PIRK-11: Switch to SLF4J with log4j2 bindings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #20: PIRK-11: Switch to SLF4J with Log4j2 bindings

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/20
  
    Please review this (its huge :) )
    1. Added slf4j with log4j2 bindings
    2. Removed LogUtils.java
    3. Modified all of the code to use slf4j loggers
    4. Java 7 compatible code cleanup, removed redundant variables 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-pirk issue #20: PIRK-11: Switch to SLF4J with Log4j2 bindings

Posted by Tim Ellison <t....@gmail.com>.
On 23/07/16 15:53, ellisonanne wrote:
> Github user ellisonanne commented on the issue:
> 
>     https://github.com/apache/incubator-pirk/pull/20
>   
>     +1 
>     
>     Phew! That's a lot of files... :)

I agree. I just had to merge them into PR#18 ;-)

Regards,
Tim

[GitHub] incubator-pirk issue #20: PIRK-11: Switch to SLF4J with Log4j2 bindings

Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:

    https://github.com/apache/incubator-pirk/pull/20
  
    +1 
    
    Phew! That's a lot of files... :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #20: PIRK-11: Switch to SLF4J with Log4j2 bindin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-pirk/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---