You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mimaison (via GitHub)" <gi...@apache.org> on 2023/01/22 11:28:29 UTC

[GitHub] [kafka] mimaison opened a new pull request, #13145: MINOR: Remove duplicate empty string check

mimaison opened a new pull request, #13145:
URL: https://github.com/apache/kafka/pull/13145

   `Values.parseString()` handles empty strings and returns the same `SchemaAndValue` [[0]](https://github.com/apache/kafka/blob/trunk/connect/api/src/main/java/org/apache/kafka/connect/data/Values.java#L383-L389) so we don't need to do the check in `toConnectHeader()`. 
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #13145: MINOR: Remove duplicate empty string check

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13145:
URL: https://github.com/apache/kafka/pull/13145#issuecomment-1446008315

   @C0urante can you take a look? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison merged pull request #13145: MINOR: Remove duplicate empty string check

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #13145:
URL: https://github.com/apache/kafka/pull/13145


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org