[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #8861: [feature-wip](statistics) step4: collect statistics by implementing statistics tasks

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on code in PR #8861:
URL: https://github.com/apache/incubator-doris/pull/8861#discussion_r867311356


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/MetaStatisticsTask.java:
##########
@@ -17,21 +17,85 @@
 
 package org.apache.doris.statistics;
 
+import org.apache.doris.catalog.Catalog;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Table;
+import org.apache.doris.common.DdlException;
+
+import com.google.common.collect.Maps;
+
 import java.util.List;
+import java.util.Map;
 
-/*
-A statistics task that directly collects statistics by reading FE meta.
+/**
+ * A statistics task that directly collects statistics by reading FE meta.
+ * e.g. for fixed-length types such as Int type and Long type we get their size from metadata.
  */

Review Comment:
   Please add comment:
   1. The granularity of row count can only be table, and the type can only be table
   2. The granularity of data size can only be table, and the type can only be table
   3. The granularity of max and min size can only be table, and the type can only be column



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org