You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/02 12:19:18 UTC
[GitHub] [incubator-yunikorn-k8shim] wilfred-s opened a new pull request #211: [YUNIKORN-475] Core dependency update
wilfred-s opened a new pull request #211:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/211
Move the shim dependency to a core without cache.
Test fixes to remove internal core object references.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #211: [YUNIKORN-475] Core dependency update
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #211:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #211: [YUNIKORN-475] Core dependency update
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #211:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/211#issuecomment-737198920
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=h1) Report
> Merging [#211](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=desc) (a0e150a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **decrease** coverage by `1.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 58.29% 57.02% -1.28%
==========================================
Files 33 32 -1
Lines 2928 2825 -103
==========================================
- Hits 1707 1611 -96
+ Misses 1149 1146 -3
+ Partials 72 68 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `66.82% <0.00%> (-4.68%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=footer). Last update [42e5a34...ff56193](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #211: [YUNIKORN-475] Core dependency update
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #211:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/211#issuecomment-737198920
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=h1) Report
> Merging [#211](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=desc) (ff56193) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 58.29% 57.38% -0.92%
==========================================
Files 33 32 -1
Lines 2928 2825 -103
==========================================
- Hits 1707 1621 -86
+ Misses 1149 1137 -12
+ Partials 72 67 -5
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=footer). Last update [42e5a34...ff56193](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #211: [YUNIKORN-475] Core dependency update
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #211:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/211#issuecomment-737198920
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=h1) Report
> Merging [#211](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=desc) (a0e150a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **decrease** coverage by `1.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 58.29% 57.02% -1.28%
==========================================
Files 33 32 -1
Lines 2928 2825 -103
==========================================
- Hits 1707 1611 -96
+ Misses 1149 1146 -3
+ Partials 72 68 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `66.82% <0.00%> (-4.68%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=footer). Last update [42e5a34...a0e150a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/211?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #211: [YUNIKORN-475] Core dependency update
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #211:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/211#issuecomment-737379695
hi @wilfred-s Looks like all the predicates related tests are failing:
```
Ran 18 of 18 Specs in 1216.121 seconds
FAIL! -- 0 Passed | 18 Failed | 0 Pending | 0 Skipped
--- FAIL: TestPredicates (1216.14s)
FAIL
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org