You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (Created) (JIRA)" <ji...@apache.org> on 2012/03/16 00:50:38 UTC
[jira] [Created] (HBASE-5589) Add of the offline call to the Master
Interface
Add of the offline call to the Master Interface
-----------------------------------------------
Key: HBASE-5589
URL: https://issues.apache.org/jira/browse/HBASE-5589
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.92.0, 0.90.6, 0.94.0, 0.96.0
Reporter: Jonathan Hsieh
Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234496#comment-13234496 ]
Hadoop QA commented on HBASE-5589:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519253/hbase-5589.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1236//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1236//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1236//console
This message is automatically generated.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5589) Add of the offline call to the Master
Interface
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5589:
----------------------------------
Status: Patch Available (was: Open)
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.92.0, 0.90.6, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235608#comment-13235608 ]
Jonathan Hsieh commented on HBASE-5589:
---------------------------------------
@Ram I believe I've fixed this. At least according to the subversion tab here on this jira, CHANGES.txt has been updated.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234535#comment-13234535 ]
stack commented on HBASE-5589:
------------------------------
bq. The 0.90 and 0.92 versions do not bump rpc to maintain compatibility but notes in comments that has been done.
You are going to bump the rpc version in 0.94. If so, please don't. We want to be able to do a rolling restart going from 0.92 to 0.94.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5589) Add of the offline call to the Master
Interface
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5589:
----------------------------------
Attachment: hbase-5588-0.94.patch
@Stack. Ok. Attached 0.94 version without the bump and with a slightly updated comment.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235464#comment-13235464 ]
ramkrishna.s.vasudevan commented on HBASE-5589:
-----------------------------------------------
@Jon
0.90 getting compilation error. Can you pls check it? Thanks.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233947#comment-13233947 ]
Jonathan Hsieh commented on HBASE-5589:
---------------------------------------
And the calling side encodes method names as part of a Writable Invocation so the interface it seems that order in the interface doesn't matter.
https://github.com/apache/hbase/blob/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java#L99
This looks to be the case in 0.90 as well.
https://github.com/apache/hbase/blob/0.90/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java#L105
Here's where I need advice. Should bump the protocol version in trunk/0.96/0.94 (HMasterInterface)? What should I do about the protocol version number released version to maintain compatibility -- specifically 0.90.x (HBaseRPCProtocolVersion) or 0.92.x (HMasterInterface)? Keep it the same?
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5589) Add of the offline call to the Master
Interface
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5589:
----------------------------------
Issue Type: Improvement (was: Sub-task)
Parent: (was: HBASE-5128)
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233952#comment-13233952 ]
stack commented on HBASE-5589:
------------------------------
@Jon OK. Then the order in the Interface is a mythology, left over from another time (maybe) when even method names were codes (though I just went back to 0.19 hbase and even there methodNames are Strings....). Good stuff.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-5589) Add of the offline call
to the Master Interface
Posted by "Jonathan Hsieh (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233450#comment-13233450 ]
Jonathan Hsieh edited comment on HBASE-5589 at 3/20/12 2:42 PM:
----------------------------------------------------------------
Found HBASE-5603 while testing rolling restart on 0.92.2-SNAPSHOT.
was (Author: jmhsieh):
Found HBASE-5603 while testing rolling upgrade on 0.92.2-SNAPSHOT.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234616#comment-13234616 ]
stack commented on HBASE-5589:
------------------------------
+1 on latest patch. Thanks Jon.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235617#comment-13235617 ]
ramkrishna.s.vasudevan commented on HBASE-5589:
-----------------------------------------------
@Jon
Sorry.. i saw it in bugs section. Just now noticed its an improvement.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233990#comment-13233990 ]
stack commented on HBASE-5589:
------------------------------
Good. Thanks.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234983#comment-13234983 ]
Hudson commented on HBASE-5589:
-------------------------------
Integrated in HBase-TRUNK #2691 (See [https://builds.apache.org/job/HBase-TRUNK/2691/])
HBASE-5589 Add of the offline call to the Master Interface (Revision 1303519)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233923#comment-13233923 ]
Jonathan Hsieh commented on HBASE-5589:
---------------------------------------
I've tested a version of this at adds the offline method "in the middle" of the HMasterInterface and then setup a cluster with a patched master (check version hash on web port) and 5 unpatched region servers (check version hash on web port). Methods below offline included balancer toggles -- I assumed that if order of declaration mattered the methods after the inserted method would have compatibility problems. The methods below were balancer() and balance_switch(bool). I fired up an shell with the prepatched version issued balancer commands. They succeeded. I fired up a shell with patch version and issued balancer commands. They also succeeded.
This might be due to some reflection/concidence with jruby so I'm going to dig into the rpc code to verify as well.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231726#comment-13231726 ]
Jonathan Hsieh commented on HBASE-5589:
---------------------------------------
Need to check to see if order matters for rolling upgrade.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235466#comment-13235466 ]
ramkrishna.s.vasudevan commented on HBASE-5589:
-----------------------------------------------
I think the CHANGES.txt is not updated for 0.90.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233943#comment-13233943 ]
Jonathan Hsieh commented on HBASE-5589:
---------------------------------------
Looks like from here the server side invocation uses method names (not an index)
https://github.com/apache/hbase/blob/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java#L322
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233967#comment-13233967 ]
Jonathan Hsieh commented on HBASE-5589:
---------------------------------------
@stack
Checked some more -- it is in the 0.2 and 0.1 branches as well.
https://github.com/apache/hbase/blob/0.1/src/java/org/apache/hadoop/hbase/ipc/HbaseRPC.java#L81
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5589) Add of the offline call to the Master
Interface
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5589:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
0.94.0
0.92.2
0.90.7
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5589) Add of the offline call to the Master
Interface
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5589:
----------------------------------
Attachment: hbase-5589.patch
hbase-5589-0.92.patch
hbase-5589-0.90.patch
hbase-5589.patch bump HMasterInterface RPC version and apply to 0.94 and trunk
The 0.90 and 0.92 versions do not bump rpc to maintain compatibility but notes in comments that has been done.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234859#comment-13234859 ]
Hadoop QA commented on HBASE-5589:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519274/hbase-5588-0.94.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1237//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1237//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1237//console
This message is automatically generated.
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235377#comment-13235377 ]
Hudson commented on HBASE-5589:
-------------------------------
Integrated in HBase-TRUNK-security #145 (See [https://builds.apache.org/job/HBase-TRUNK-security/145/])
HBASE-5589 Add of the offline call to the Master Interface (Revision 1303519)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Jonathan Hsieh (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh reassigned HBASE-5589:
-------------------------------------
Assignee: Jonathan Hsieh
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235296#comment-13235296 ]
Hudson commented on HBASE-5589:
-------------------------------
Integrated in HBase-0.92 #334 (See [https://builds.apache.org/job/HBase-0.92/334/])
HBASE-5589 Add of the offline call to the Master Interface (Revision 1303621)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5589) Add of the offline call to the
Master Interface
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235054#comment-13235054 ]
Hudson commented on HBASE-5589:
-------------------------------
Integrated in HBase-0.94 #45 (See [https://builds.apache.org/job/HBase-0.94/45/])
HBASE-5589 Add of the offline call to the Master Interface (Revision 1303520)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Add of the offline call to the Master Interface
> -----------------------------------------------
>
> Key: HBASE-5589
> URL: https://issues.apache.org/jira/browse/HBASE-5589
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.6, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.94.patch, hbase-5589-0.90.patch, hbase-5589-0.92.patch, hbase-5589.patch
>
>
> Hbck from HBASE-5128 requires an offline method on the master to properly cleanup state during certain assignment repair operations. This will this method will be added to recent and older versions of HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira