You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2021/07/07 23:30:52 UTC
[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3699: Added support for adding Kubernetes annotations to the topology pod and service
nwangtw commented on a change in pull request #3699:
URL: https://github.com/apache/incubator-heron/pull/3699#discussion_r665768140
##########
File path: heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/KubernetesContext.java
##########
@@ -83,6 +88,11 @@
public static final String HERON_KUBERNETES_CONTAINER_VOLUME_MOUNT_PATH =
"heron.kubernetes.container.volumeMount.path";
+ public static final String HERON_KUBERNETES_POD_ANNOTATION =
+ "heron.kubernetes.pod.annotation.";
+ public static final String HERON_KUBERNETES_SERVICE_ANNOTATION =
+ "heron.kubernetes.service.annotation.";
Review comment:
nit: inconsistent indent
##########
File path: heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/KubernetesContext.java
##########
@@ -152,6 +162,36 @@ static String getContainerVolumeMountPath(Config config) {
return config.getStringValue(HERON_KUBERNETES_CONTAINER_VOLUME_MOUNT_PATH);
}
+ static Set<String> getConfigKeys(Config config, String key) {
Review comment:
`keyPrefix` might be more explicit than `key`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org