You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/11/09 21:17:47 UTC
[GitHub] [lucene-solr] jtibshirani opened a new pull request #2070: LUCENE-9536: Correct the OrdinalMap optimization.
jtibshirani opened a new pull request #2070:
URL: https://github.com/apache/lucene-solr/pull/2070
Previously we only checked that the first segment's ordinal deltas were all
zero. This didn't account for some rare cases where some of the segment's
ordinals are filtered out, so the ordinals aren't contiguous. In these cases we
fill in dummy values for the missing ordinal deltas. So a segment's ordinals
can appear to match the global ordinals perfectly, but not actually contain all
the terms.
Such a case can arise when using a FilteredTermsEnum, for example when merging
a segment with deletions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on pull request #2070: LUCENE-9536: Correct the OrdinalMap optimization.
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #2070:
URL: https://github.com/apache/lucene-solr/pull/2070#issuecomment-724288495
This should fix the failures we're seeing like `TestLucene70DocValuesFormat#testSparseSortedVariableLengthVsStoredFields` and `TestSimpleTextDocValuesFormat#testSparseSortedFixedLengthVsStoredFields`. Note to self: run the whole test suite a bunch of times when changing subtle logic!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz merged pull request #2070: LUCENE-9536: Correct the OrdinalMap optimization.
Posted by GitBox <gi...@apache.org>.
jpountz merged pull request #2070:
URL: https://github.com/apache/lucene-solr/pull/2070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org