You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/27 17:20:24 UTC

[GitHub] [arrow] kiszk commented on a change in pull request #7556: ARROW-9188: [C++] Use Brotli shared libraries if they are available

kiszk commented on a change in pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#discussion_r446547216



##########
File path: cpp/cmake_modules/FindBrotli.cmake
##########
@@ -17,29 +17,29 @@
 #
 #  find_package(Brotli)
 
-# Favour static libraries over dynamic libraries, and handle various spellings
+# Favor shared libraries over dynamic libraries, and handle various spellings

Review comment:
       nit: dynamic -> static ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org