[GitHub] [pulsar] eolivelli commented on a change in pull request #7555: Modify the log level of functions and move the java_instance_log4j2.xml file from the jar package to the conf directory

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #7555:
URL: https://github.com/apache/pulsar/pull/7555#discussion_r557415327



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java
##########
@@ -127,7 +127,12 @@ private static void getTopicStats(Topic topic, TopicStats stats, boolean include
                 stats.throughputIn += producer.getStats().msgThroughputIn;
             }
         });
-
+        topic.getSubscriptions().values().forEach(sub->{

Review comment:
       This change seems unrelated, please create another pr foe this

##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/process/ProcessRuntime.java
##########
@@ -106,6 +106,10 @@
         switch (instanceConfig.getFunctionDetails().getRuntime()) {
             case JAVA:
                 logConfigFile = "java_instance_log4j2.xml";
+                String palsarHome = System.getenv("PULSAR_HOME");
+                if(palsarHome!=null&&!palsarHome.trim().isEmpty()){
+                    logConfigFile = palsarHome+ "/conf/java_instance_log4j2.xml";

Review comment:
       Can we use a more user friendly name?
   Like pulsar_functions_log4j2.xml




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org