You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/28 07:41:57 UTC

[GitHub] [incubator-seatunnel] MRYOG opened a new pull request, #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

MRYOG opened a new pull request, #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285

   Add Dingtalk Sink #2257 ,incloud sink and api example


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1200659757

   Please fix ci error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG closed pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG closed pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257
URL: https://github.com/apache/incubator-seatunnel/pull/2285


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on a diff in pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG commented on code in PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#discussion_r933978956


##########
seatunnel-connectors-v2/connector-dingtalk/src/main/java/org/apache/seatunnel/connectors/seatunnel/sink/DingTalkSink.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.sink;
+
+import org.apache.seatunnel.api.common.PrepareFailException;
+import org.apache.seatunnel.api.sink.SeaTunnelSink;
+import org.apache.seatunnel.api.sink.SinkWriter;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSimpleSink;
+import org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSinkWriter;
+
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+
+import com.google.auto.service.AutoService;
+
+import java.io.IOException;
+
+/**
+ * DingTalk sink class
+ */
+@AutoService(SeaTunnelSink.class)
+public class DingTalkSink extends AbstractSimpleSink<SeaTunnelRow, Void> {
+  private Config pluginConfig;
+  private SeaTunnelRowType seaTunnelRowType;
+  @Override
+  public String getPluginName() {
+    return "DingTalk";
+  }
+
+  @Override
+  public void prepare(Config pluginConfig) throws PrepareFailException {
+    this.pluginConfig = pluginConfig;

Review Comment:
   done



##########
seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/java/org/apache/seatunnel/example/flink/v2/SeaTunnelApiExample.java:
##########
@@ -31,7 +31,7 @@
 public class SeaTunnelApiExample {
 
     public static void main(String[] args) throws FileNotFoundException, URISyntaxException, CommandException {
-        String configFile = getTestConfigFile("/examples/fake_to_console.conf");
+        String configFile = getTestConfigFile("/examples/fake_to_dingtalk.conf");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1200657092

   > add doc , dingtalk.md add v2-dist pom.xml add plugin-mapping.properties add DingTalk example fix {reversion} confim vcs.xml , pom.xml
   
   It's done 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] ic4y commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1197787273

   cc @Hisoka-X 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#discussion_r931895652


##########
pom.xml:
##########
@@ -87,7 +87,7 @@
         <module>seatunnel-plugin-discovery</module>
         <module>seatunnel-formats</module>
         <module>seatunnel-dist</module>
-	    <module>seatunnel-server</module>
+	      <module>seatunnel-server</module>

Review Comment:
   ```suggestion
   	  <module>seatunnel-server</module>
   ```



##########
seatunnel-connectors-v2/connector-dingtalk/pom.xml:
##########
@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <parent>
+    <artifactId>seatunnel-connectors-v2</artifactId>
+    <groupId>org.apache.seatunnel</groupId>
+    <version>2.1.3-SNAPSHOT</version>
+  </parent>
+  <modelVersion>4.0.0</modelVersion>
+
+  <artifactId>connector-dingtalk</artifactId>
+
+  <properties>

Review Comment:
   Please remove maven jdk version. We should make sure our connector can compiled success both on jdk8 and jdk11.



##########
seatunnel-connectors-v2/connector-dingtalk/pom.xml:
##########
@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <parent>
+    <artifactId>seatunnel-connectors-v2</artifactId>
+    <groupId>org.apache.seatunnel</groupId>
+    <version>2.1.3-SNAPSHOT</version>

Review Comment:
   ```suggestion
       <version>${revision}</version>
   ```



##########
seatunnel-connectors-v2/connector-dingtalk/src/main/java/org/apache/seatunnel/connectors/seatunnel/sink/DingTalkSink.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.sink;
+
+import org.apache.seatunnel.api.common.PrepareFailException;
+import org.apache.seatunnel.api.sink.SeaTunnelSink;
+import org.apache.seatunnel.api.sink.SinkWriter;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSimpleSink;
+import org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSinkWriter;
+
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+
+import com.google.auto.service.AutoService;
+
+import java.io.IOException;
+
+/**
+ * DingTalk sink class
+ */
+@AutoService(SeaTunnelSink.class)
+public class DingTalkSink extends AbstractSimpleSink<SeaTunnelRow, Void> {
+  private Config pluginConfig;
+  private SeaTunnelRowType seaTunnelRowType;
+  @Override
+  public String getPluginName() {
+    return "DingTalk";
+  }
+
+  @Override
+  public void prepare(Config pluginConfig) throws PrepareFailException {
+    this.pluginConfig = pluginConfig;

Review Comment:
   Please check your config, make sure `url` and `secret` parameter must included in pluginConfig.



##########
seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/java/org/apache/seatunnel/example/flink/v2/SeaTunnelApiExample.java:
##########
@@ -31,7 +31,7 @@
 public class SeaTunnelApiExample {
 
     public static void main(String[] args) throws FileNotFoundException, URISyntaxException, CommandException {
-        String configFile = getTestConfigFile("/examples/fake_to_console.conf");
+        String configFile = getTestConfigFile("/examples/fake_to_dingtalk.conf");

Review Comment:
   Please don't change this default config. We should make sure other developer can run this example easy. You can create a SeaTunnelDingTaskExample.java or create a e2e test for DingTalk.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1197817572

   Got it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1200796542

   
   
   
   > > Sorry, my checkstyle is not seatunnel config, so it has many problem.
   > 
   > SeaTunnel checkstyle file in `tools/checkstyle`
   
   Yes,I fix it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1197971850

   > Please add the document for this connector. The path is `docs/en/connector-v2/sink`. Thanks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1200415988

   add doc , dingtalk.md
   add v2-dist  pom.xml
   add  plugin-mapping.properties
   add DingTalk example
   fix {reversion}
   confim vcs.xml , pom.xml
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1200778080

   Sorry, my checkstyle is not seatunnel config, so it has many problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1198843368

   Please add `connector-dingtalk` to `seatunnel-connector-v2-dist/pom.xml`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on a diff in pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
MRYOG commented on code in PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#discussion_r933978867


##########
pom.xml:
##########
@@ -87,7 +87,7 @@
         <module>seatunnel-plugin-discovery</module>
         <module>seatunnel-formats</module>
         <module>seatunnel-dist</module>
-	    <module>seatunnel-server</module>
+	      <module>seatunnel-server</module>

Review Comment:
   done



##########
seatunnel-connectors-v2/connector-dingtalk/pom.xml:
##########
@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <parent>
+    <artifactId>seatunnel-connectors-v2</artifactId>
+    <groupId>org.apache.seatunnel</groupId>
+    <version>2.1.3-SNAPSHOT</version>

Review Comment:
   done



##########
seatunnel-connectors-v2/connector-dingtalk/pom.xml:
##########
@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <parent>
+    <artifactId>seatunnel-connectors-v2</artifactId>
+    <groupId>org.apache.seatunnel</groupId>
+    <version>2.1.3-SNAPSHOT</version>
+  </parent>
+  <modelVersion>4.0.0</modelVersion>
+
+  <artifactId>connector-dingtalk</artifactId>
+
+  <properties>

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1201932053

   cc @CalvinKirs  @Hisoka-X  First-time contributors need a maintainer to approve running workflow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1200337513

   Hi Please resolve ci problem. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1200786814

   > Sorry, my checkstyle is not seatunnel config, so it has many problem.
   
   SeaTunnel checkstyle file in `tools/checkstyle`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2285: [Feature][Connector-V2] Add Dingtalk Sink #2257

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2285:
URL: https://github.com/apache/incubator-seatunnel/pull/2285#issuecomment-1197808100

   Also please add DingTalk properties to plugin-mapping.properties file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org