You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2016/02/26 18:11:29 UTC
spark git commit: [MINOR][SQL] Fix modifier order.
Repository: spark
Updated Branches:
refs/heads/master 7af0de076 -> 727e78014
[MINOR][SQL] Fix modifier order.
## What changes were proposed in this pull request?
This PR fixes the order of modifier from `abstract public` into `public abstract`.
Currently, when we run `./dev/lint-java`, it shows the error.
```
Checkstyle checks failed at following occurrences:
[ERROR] src/main/java/org/apache/spark/util/sketch/CountMinSketch.java:[53,10] (modifier) ModifierOrder: 'public' modifier out of order with the JLS suggestions.
```
## How was this patch tested?
```
$ ./dev/lint-java
Checkstyle checks passed.
```
Author: Dongjoon Hyun <do...@apache.org>
Closes #11390 from dongjoon-hyun/fix_modifier_order.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/727e7801
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/727e7801
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/727e7801
Branch: refs/heads/master
Commit: 727e78014fd4957e477d62adc977fa4da3e3455d
Parents: 7af0de0
Author: Dongjoon Hyun <do...@apache.org>
Authored: Fri Feb 26 17:11:19 2016 +0000
Committer: Sean Owen <so...@cloudera.com>
Committed: Fri Feb 26 17:11:19 2016 +0000
----------------------------------------------------------------------
.../src/main/java/org/apache/spark/util/sketch/CountMinSketch.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/727e7801/common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java
----------------------------------------------------------------------
diff --git a/common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java b/common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java
index 2c9aa93..40fa20c 100644
--- a/common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java
+++ b/common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java
@@ -50,7 +50,7 @@ import java.io.OutputStream;
*
* This implementation is largely based on the {@code CountMinSketch} class from stream-lib.
*/
-abstract public class CountMinSketch {
+public abstract class CountMinSketch {
public enum Version {
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org