You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2023/07/17 03:41:00 UTC
[GitHub] [spark] asl3 opened a new pull request, #42031: [SPARK-44453][PYTHON] Use difflib to display errors in assertDataFrameEqual
asl3 opened a new pull request, #42031:
URL: https://github.com/apache/spark/pull/42031
### What changes were proposed in this pull request?
This PR uses the built-in Python library, difflib, to display errors in the testing util `assertDataFrameEqual`
### Why are the changes needed?
The change makes the error message output more user-friendly, as well as consistent with `assertSchemaEqual`
### Does this PR introduce _any_ user-facing change?
Yes, the PR changes the test util output for the user-facing util function `assertDataFrameEqual`.
### How was this patch tested?
Existing tests in `runtime/python/pyspark/sql/tests/test_utils.py` and `runtime/python/pyspark/sql/tests/connect/test_utils.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42031: [SPARK-44453][PYTHON] Use difflib to display errors in assertDataFrameEqual
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42031:
URL: https://github.com/apache/spark/pull/42031#issuecomment-1639025848
Merged to master and branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42031: [SPARK-44453][PYTHON] Use difflib to display errors in assertDataFrameEqual
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42031: [SPARK-44453][PYTHON] Use difflib to display errors in assertDataFrameEqual
URL: https://github.com/apache/spark/pull/42031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org