[jira] [Commented] (WICKET-6673) PriorityHeaderItem ordering is wrong for siblings

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927474#comment-16927474 ] 

ASF subversion and git services commented on WICKET-6673:
---------------------------------------------------------

Commit 5af5c0539c421851c224c012accadb482d93987e in wicket's branch refs/heads/master from Sven Meier
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=5af5c05 ]

WICKET-6673 priority items based on depth

restored some information of RecordedHeaderItem in case someone
needs this in their comparator implementation

> PriorityHeaderItem ordering is wrong for siblings
> -------------------------------------------------
>
>                 Key: WICKET-6673
>                 URL: https://issues.apache.org/jira/browse/WICKET-6673
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 9
>            Reporter: Sven Meier
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 9.0.0-M3
>
>
> PriorityHeaderItems allows parents to move their header items infront of those of their children (_parent-first_ instead of _child-first_).
> But the current implemention sorts PriorityHeaderItems of siblings in reverse order, e.g. having a component hierarchy as follows:
> {code:java}
> Component A
> +- Component AA
> +- Component AB
> {code}
> ... the PriorityHeaderItems of all these components are sorted as:
> {code:java}
> - PriorityHeaderItem of A
> - PriorityHeaderItem of AB
> - PriorityHeaderItem of AA
> {code}
> Why should the PriorityHeaderItem of component AB be before that of AA? This isn't _parent-first_, it is _reverse-order_.
> IMHO a more suitable ordering would be "_parent-first-preserving-siblings"_:
> {code:java}
> - PriorityHeaderItem of A
> - PriorityHeaderItem of AA
> - PriorityHeaderItem of AB
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)