You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/07/14 03:06:14 UTC
[jira] Created: (HBASE-1650) HBASE-1551 broke the ability to manage
non-regionserver start-up/shut down. ie: you cant start/stop thrift on a
cluster anymore
HBASE-1551 broke the ability to manage non-regionserver start-up/shut down. ie: you cant start/stop thrift on a cluster anymore
-------------------------------------------------------------------------------------------------------------------------------
Key: HBASE-1650
URL: https://issues.apache.org/jira/browse/HBASE-1650
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.20.0
Reporter: ryan rawson
Priority: Blocker
Fix For: 0.20.0
I used to be able to do:
bin/hbase-daemons.sh stop thrift
bin/hbase-daemons.sh start thrift
I can't anymore. We can't manage anything but regionservers and zookeeper with this script now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1650) HBASE-1551 broke the ability to
manage non-regionserver start-up/shut down. ie: you cant start/stop thrift
on a cluster anymore
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731005#action_12731005 ]
Andrew Purtell commented on HBASE-1650:
---------------------------------------
+1
> HBASE-1551 broke the ability to manage non-regionserver start-up/shut down. ie: you cant start/stop thrift on a cluster anymore
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1650
> URL: https://issues.apache.org/jira/browse/HBASE-1650
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: stack
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 1650.patch
>
>
> I used to be able to do:
> bin/hbase-daemons.sh stop thrift
> bin/hbase-daemons.sh start thrift
> I can't anymore. We can't manage anything but regionservers and zookeeper with this script now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1650) HBASE-1551 broke the ability to
manage non-regionserver start-up/shut down. ie: you cant start/stop thrift
on a cluster anymore
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1650.
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Thanks for review Andrew. Committed.
> HBASE-1551 broke the ability to manage non-regionserver start-up/shut down. ie: you cant start/stop thrift on a cluster anymore
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1650
> URL: https://issues.apache.org/jira/browse/HBASE-1650
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: stack
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 1650.patch
>
>
> I used to be able to do:
> bin/hbase-daemons.sh stop thrift
> bin/hbase-daemons.sh start thrift
> I can't anymore. We can't manage anything but regionservers and zookeeper with this script now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1650) HBASE-1551 broke the ability to manage
non-regionserver start-up/shut down. ie: you cant start/stop thrift on a
cluster anymore
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1650:
-------------------------
Attachment: 1650.patch
Suggested fix.
> HBASE-1551 broke the ability to manage non-regionserver start-up/shut down. ie: you cant start/stop thrift on a cluster anymore
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1650
> URL: https://issues.apache.org/jira/browse/HBASE-1650
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 1650.patch
>
>
> I used to be able to do:
> bin/hbase-daemons.sh stop thrift
> bin/hbase-daemons.sh start thrift
> I can't anymore. We can't manage anything but regionservers and zookeeper with this script now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1650) HBASE-1551 broke the ability to
manage non-regionserver start-up/shut down. ie: you cant start/stop thrift
on a cluster anymore
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730660#action_12730660 ]
stack commented on HBASE-1650:
------------------------------
So, here is offending change:
{code}
diff --git a/bin/hbase-daemons.sh b/bin/hbase-daemons.sh
index 166af33..5af9408 100755
--- a/bin/hbase-daemons.sh
+++ b/bin/hbase-daemons.sh
@@ -37,6 +37,20 @@ bin=`cd "$bin"; pwd`
. $bin/hbase-config.sh
-exec "$bin/regionservers.sh" --config "${HBASE_CONF_DIR}" \
- cd "${HBASE_HOME}" \; \
- "$bin/hbase-daemon.sh" --config "${HBASE_CONF_DIR}" "$@"
+remote_cmd="cd ${HBASE_HOME}; $bin/hbase-daemon.sh --config ${HBASE_CONF_DIR} $@"
+args="--config ${HBASE_CONF_DIR} $remote_cmd"
+
+command=$2
+case $command in
+ (regionserver)
+ exec "$bin/regionservers.sh" $args
+ ;;
+ (zookeeper)
+ exec "$bin/zookeepers.sh" $args
+ ;;
+ (*)
+ echo $usage
+ exit 1
+ ;;
+esac
+
{code}
Rather than print usage, running with regionservers should be default?
> HBASE-1551 broke the ability to manage non-regionserver start-up/shut down. ie: you cant start/stop thrift on a cluster anymore
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1650
> URL: https://issues.apache.org/jira/browse/HBASE-1650
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Priority: Blocker
> Fix For: 0.20.0
>
>
> I used to be able to do:
> bin/hbase-daemons.sh stop thrift
> bin/hbase-daemons.sh start thrift
> I can't anymore. We can't manage anything but regionservers and zookeeper with this script now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-1650) HBASE-1551 broke the ability to
manage non-regionserver start-up/shut down. ie: you cant start/stop thrift
on a cluster anymore
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-1650:
----------------------------
Assignee: stack
> HBASE-1551 broke the ability to manage non-regionserver start-up/shut down. ie: you cant start/stop thrift on a cluster anymore
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1650
> URL: https://issues.apache.org/jira/browse/HBASE-1650
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: stack
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 1650.patch
>
>
> I used to be able to do:
> bin/hbase-daemons.sh stop thrift
> bin/hbase-daemons.sh start thrift
> I can't anymore. We can't manage anything but regionservers and zookeeper with this script now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1650) HBASE-1551 broke the ability to
manage non-regionserver start-up/shut down. ie: you cant start/stop thrift
on a cluster anymore
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731021#action_12731021 ]
ryan rawson commented on HBASE-1650:
------------------------------------
+1 lets do it
> HBASE-1551 broke the ability to manage non-regionserver start-up/shut down. ie: you cant start/stop thrift on a cluster anymore
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1650
> URL: https://issues.apache.org/jira/browse/HBASE-1650
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: stack
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 1650.patch
>
>
> I used to be able to do:
> bin/hbase-daemons.sh stop thrift
> bin/hbase-daemons.sh start thrift
> I can't anymore. We can't manage anything but regionservers and zookeeper with this script now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.