[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #221: Fix for type.getType(...) use on non-signature type names

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on code in PR #221:
URL: https://github.com/apache/commons-bcel/pull/221#discussion_r1317176598


##########
src/main/java/org/apache/bcel/generic/Type.java:
##########
@@ -365,6 +366,24 @@ public int hashCode() {
         return type ^ signature.hashCode();
     }
 
+    static String internalTypeNameToSignature(final String internalTypeName) {
+        if (StringUtils.isEmpty(internalTypeName) || StringUtils.equalsAny(internalTypeName, "B", "C", "D", "F", "I", "J", "S", "Z")) {
+            return internalTypeName;

Review Comment:
   Sometime this week...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org