You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/13 16:03:57 UTC

[GitHub] [incubator-nuttx] diegoherranz opened a new pull request, #6849: drivers/leds/ws2812: Revert SPI frequency change

diegoherranz opened a new pull request, #6849:
URL: https://github.com/apache/incubator-nuttx/pull/6849

   ## Summary
   
   https://github.com/apache/incubator-nuttx/commit/0c3db448bb64c8877a4dfa62416027b24a639a8e added the option to generate the waveforms to drive ws2812 and similar LEDs using different hardware (e.g. RP2040 PIO instead of SPI).
   
   For that new mode, the concept of CONFIG_WS2812_FREQUENCY is different. Instead of the SPI frequency (commonly a few MHz), it is the frequency of the actual output waveform (commonly 400 or 800 kHz).
   
   There was an attempt to express the SPI frequency divided by 10, but it's not actually the case either (it would be divided by 8).
   
   I think it is clearer to explain in Kconfig what CONFIG_WS2812_FREQUENCY means for each mode and go back to the previous behaviour for the original SPI mode (also to avoid breaking out-of-tree boards).
   
   ## Impact
   ws2812 driver only. And only for the original SPI mode.
   It restores the previous behaviour of the driver, so this, in fact, avoids impact for out-of-tree boards.
   
   ## Testing
   I don't have the custom board that I normally use at hand today to test it, but this should only revert the previous behaviour.
   
   Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] curuvar commented on pull request #6849: drivers/leds/ws2812: Revert SPI frequency change

Posted by GitBox <gi...@apache.org>.
curuvar commented on PR #6849:
URL: https://github.com/apache/incubator-nuttx/pull/6849#issuecomment-1214184851

   I have no problem with this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] diegoherranz commented on pull request #6849: drivers/leds/ws2812: Revert SPI frequency change

Posted by GitBox <gi...@apache.org>.
diegoherranz commented on PR #6849:
URL: https://github.com/apache/incubator-nuttx/pull/6849#issuecomment-1214190424

   Thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #6849: drivers/leds/ws2812: Revert SPI frequency change

Posted by GitBox <gi...@apache.org>.
btashton merged PR #6849:
URL: https://github.com/apache/incubator-nuttx/pull/6849


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org