You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/08/07 13:23:51 UTC
[GitHub] [incubator-pekko-http] He-Pin opened a new pull request, #297: !sbt Use multiJvmPlugin from pekko.
He-Pin opened a new pull request, #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297
Just copy code from pekko, better to submit this upstream, will do later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669002533
> approved as temporary solution - if it doesn't help, we should probably revert this - if it does work, we should be looking at creating a shared sbt plugin with this change
@pjfanning This is probably a good candidate to include in the `incubator-pekko-sbt-build` I was talking about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin merged pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669146255
Let's me submit a fix and then this code will not be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669114367
Where did the problem occur and how was it fixed? Which kubernetes cluster
are we connecting against here?
Matthew de Detrich ***@***.***> schrieb am Di., 8. Aug. 2023,
09:12:
> @He-Pin <https://github.com/He-Pin> Lets discuss in
> apache/incubator-pekko#548
> <https://github.com/apache/incubator-pekko/issues/548>
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669035978>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAACNDEG5VDHOCYWBI3UUMDXUHRHTANCNFSM6AAAAAA3G73I7A>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669019499
> That's true, the sbt one seems unmaintained at least for now.
I assume you are talking about https://github.com/sbt/sbt-multi-jvm? If so do you know for what reasons we aren't using this plugin, i.e. is it missing anything? Rather than having all of this extra code that we have to maintain ourselves its always ideal to use an upstream version and while its true that it hasn't really been maintained, the current sbt maintainers are very responsive when it comes to accepting upstream PR's.
If its shown that you are doing extensive contributions to an sbt community project they can add you as maintainers (I am already a maintainer for sbt-github-actions for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669033563
@mdedetrich
1. We need wait the `Controller` transited to connectable before start the `Player`.
2. Need submit a PR to `sbt-multi-jvm` and waiting a new snapshot, which may take sometimes and is not a *quick fix*.
3. I did not diff the code with sbt-multi-jvm line by line, but there must be some reason for Akka was keep it separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1668220511
What problem does it solve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1668280074
> What problem does it solve?
>
It start the Player only after The Controller can be connected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669133498
@jrudolph After migrate the `netty3` to `netty4`, the `Contoller` part which started at `index==0` seems not bind faster enough. The thread model has been changed in netty 4, or the max attept in the `Player` can be changed to a larger value, does that's what you expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669035978
@He-Pin Lets discuss in https://github.com/apache/incubator-pekko/issues/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #297: !sbt Use multiJvmPlugin from pekko.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #297:
URL: https://github.com/apache/incubator-pekko-http/pull/297#issuecomment-1669011499
That's true, the sbt one seems unmaintained at least for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org