[GitHub] [druid] cryptoe commented on a diff in pull request #14166: Relaunch track of failed workers without work orders

["cryptoe (via GitHub)" <gi...@apache.org>]

cryptoe commented on code in PR #14166:
URL: https://github.com/apache/druid/pull/14166#discussion_r1177403646


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTaskLauncher.java:
##########
@@ -221,6 +225,17 @@ public List<String> getActiveTasks()
    */
   public void launchTasksIfNeeded(final int taskCount) throws InterruptedException
   {
+    // Fetch the list of workers which failed without work orders
+    Iterator<Integer> iterator = failedInactiveWorkers.iterator();

Review Comment:
   This has to be in the synchronized (taskIds) block since multiple threads can call  `launchTasksIfNeeded`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org