You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Erik Pilz (JIRA)" <ji...@apache.org> on 2007/01/03 23:21:16 UTC
[jira] Created: (WW-1593) ExecuteAndWaitInterceptor no longer works
after upgrading from WebWork 2.2.4
ExecuteAndWaitInterceptor no longer works after upgrading from WebWork 2.2.4
----------------------------------------------------------------------------
Key: WW-1593
URL: https://issues.apache.org/struts/browse/WW-1593
Project: Struts 2
Issue Type: Bug
Components: Interceptors
Affects Versions: 2.0.1, 2.0.2
Environment: Sun JDK 1.5; WinXP; WebLogic 9.2
Reporter: Erik Pilz
Priority: Critical
After upgrading from WebWork 2.2.4 to Struts 2.0.2-SNAPSHOT the actions that use the ExecuteAndWaitInterceptor no longer work. Looking at the changes to the interceptor it appears that the changes to add the "executeAfterValidationPass" property are causing the problem.
To support this feature a new local variable "secondTime", which defaults to true, was added to the doIntercept() method. Later in the code are various checks to determine what result should be returned. The following is a condensed version of the if-else:
if (!secondTime && bp != null && !bp.isDone()) {
return WAIT;
} else if (!secondTime && bp != null && bp.isDone()) {
return bp.getResult();
} else {
return actionInvocation.invoke();
}
Looking at the code I can't see how the "secondTime" variable can ever be set to false except on the first iteration or if you're using the "executeAfterValidationPass" property.
The workaround for now is to use the ExecuteAndWaitInterceptor that ships with WebWork 2.2.4.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1593) ExecuteAndWaitInterceptor no longer works
after upgrading from WebWork 2.2.4
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-1593:
--------------------------
Fix Version/s: 2.0.2
Assignee: Don Brown
I wondered the same thing...
> ExecuteAndWaitInterceptor no longer works after upgrading from WebWork 2.2.4
> ----------------------------------------------------------------------------
>
> Key: WW-1593
> URL: https://issues.apache.org/struts/browse/WW-1593
> Project: Struts 2
> Issue Type: Bug
> Components: Interceptors
> Affects Versions: 2.0.1, 2.0.2
> Environment: Sun JDK 1.5; WinXP; WebLogic 9.2
> Reporter: Erik Pilz
> Assigned To: Don Brown
> Fix For: 2.0.3
>
>
> After upgrading from WebWork 2.2.4 to Struts 2.0.2-SNAPSHOT the actions that use the ExecuteAndWaitInterceptor no longer work. Looking at the changes to the interceptor it appears that the changes to add the "executeAfterValidationPass" property are causing the problem.
> To support this feature a new local variable "secondTime", which defaults to true, was added to the doIntercept() method. Later in the code are various checks to determine what result should be returned. The following is a condensed version of the if-else:
> if (!secondTime && bp != null && !bp.isDone()) {
> return WAIT;
> } else if (!secondTime && bp != null && bp.isDone()) {
> return bp.getResult();
> } else {
> return actionInvocation.invoke();
> }
> Looking at the code I can't see how the "secondTime" variable can ever be set to false except on the first iteration or if you're using the "executeAfterValidationPass" property.
> The workaround for now is to use the ExecuteAndWaitInterceptor that ships with WebWork 2.2.4.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1593) ExecuteAndWaitInterceptor no longer
works after upgrading from WebWork 2.2.4
Posted by "Erik Pilz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39656 ]
Erik Pilz commented on WW-1593:
-------------------------------
Also, if anyone can point to the use case for "executeAfterValidationPass" property I'd appreciate it. On the surface it isn't clear to me when this property is useful.
Thanks,
Erik
> ExecuteAndWaitInterceptor no longer works after upgrading from WebWork 2.2.4
> ----------------------------------------------------------------------------
>
> Key: WW-1593
> URL: https://issues.apache.org/struts/browse/WW-1593
> Project: Struts 2
> Issue Type: Bug
> Components: Interceptors
> Affects Versions: 2.0.1, 2.0.2
> Environment: Sun JDK 1.5; WinXP; WebLogic 9.2
> Reporter: Erik Pilz
>
> After upgrading from WebWork 2.2.4 to Struts 2.0.2-SNAPSHOT the actions that use the ExecuteAndWaitInterceptor no longer work. Looking at the changes to the interceptor it appears that the changes to add the "executeAfterValidationPass" property are causing the problem.
> To support this feature a new local variable "secondTime", which defaults to true, was added to the doIntercept() method. Later in the code are various checks to determine what result should be returned. The following is a condensed version of the if-else:
> if (!secondTime && bp != null && !bp.isDone()) {
> return WAIT;
> } else if (!secondTime && bp != null && bp.isDone()) {
> return bp.getResult();
> } else {
> return actionInvocation.invoke();
> }
> Looking at the code I can't see how the "secondTime" variable can ever be set to false except on the first iteration or if you're using the "executeAfterValidationPass" property.
> The workaround for now is to use the ExecuteAndWaitInterceptor that ships with WebWork 2.2.4.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1593) ExecuteAndWaitInterceptor no longer works
after upgrading from WebWork 2.2.4
Posted by "Erik Pilz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Pilz updated WW-1593:
--------------------------
Priority: Major (was: Critical)
I accidentally set the status to Critical. I'll leave it up to whomever is assigned the bug to adjust the setting.
Cheers,
Erik
> ExecuteAndWaitInterceptor no longer works after upgrading from WebWork 2.2.4
> ----------------------------------------------------------------------------
>
> Key: WW-1593
> URL: https://issues.apache.org/struts/browse/WW-1593
> Project: Struts 2
> Issue Type: Bug
> Components: Interceptors
> Affects Versions: 2.0.1, 2.0.2
> Environment: Sun JDK 1.5; WinXP; WebLogic 9.2
> Reporter: Erik Pilz
>
> After upgrading from WebWork 2.2.4 to Struts 2.0.2-SNAPSHOT the actions that use the ExecuteAndWaitInterceptor no longer work. Looking at the changes to the interceptor it appears that the changes to add the "executeAfterValidationPass" property are causing the problem.
> To support this feature a new local variable "secondTime", which defaults to true, was added to the doIntercept() method. Later in the code are various checks to determine what result should be returned. The following is a condensed version of the if-else:
> if (!secondTime && bp != null && !bp.isDone()) {
> return WAIT;
> } else if (!secondTime && bp != null && bp.isDone()) {
> return bp.getResult();
> } else {
> return actionInvocation.invoke();
> }
> Looking at the code I can't see how the "secondTime" variable can ever be set to false except on the first iteration or if you're using the "executeAfterValidationPass" property.
> The workaround for now is to use the ExecuteAndWaitInterceptor that ships with WebWork 2.2.4.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1593) ExecuteAndWaitInterceptor no longer works
after upgrading from WebWork 2.2.4
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-1593:
--------------------------
Fix Version/s: (was: 2.0.2)
2.0.3
> ExecuteAndWaitInterceptor no longer works after upgrading from WebWork 2.2.4
> ----------------------------------------------------------------------------
>
> Key: WW-1593
> URL: https://issues.apache.org/struts/browse/WW-1593
> Project: Struts 2
> Issue Type: Bug
> Components: Interceptors
> Affects Versions: 2.0.1, 2.0.2
> Environment: Sun JDK 1.5; WinXP; WebLogic 9.2
> Reporter: Erik Pilz
> Assigned To: Don Brown
> Fix For: 2.0.3
>
>
> After upgrading from WebWork 2.2.4 to Struts 2.0.2-SNAPSHOT the actions that use the ExecuteAndWaitInterceptor no longer work. Looking at the changes to the interceptor it appears that the changes to add the "executeAfterValidationPass" property are causing the problem.
> To support this feature a new local variable "secondTime", which defaults to true, was added to the doIntercept() method. Later in the code are various checks to determine what result should be returned. The following is a condensed version of the if-else:
> if (!secondTime && bp != null && !bp.isDone()) {
> return WAIT;
> } else if (!secondTime && bp != null && bp.isDone()) {
> return bp.getResult();
> } else {
> return actionInvocation.invoke();
> }
> Looking at the code I can't see how the "secondTime" variable can ever be set to false except on the first iteration or if you're using the "executeAfterValidationPass" property.
> The workaround for now is to use the ExecuteAndWaitInterceptor that ships with WebWork 2.2.4.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WW-1593) ExecuteAndWaitInterceptor no longer
works after upgrading from WebWork 2.2.4
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown resolved WW-1593.
---------------------------
Resolution: Fixed
Of course, I was the one that added that parameter :) The history is patrick added support for validation so that the background process wouldn't happen right away, but unfortunately, it forced you to always use validation. I added that parameter to allow validation support to be optional. Unfortunately, it seems it still didn't work correctly for non-validation requests. Should be fixed now. Thanks for pointing this out!
> ExecuteAndWaitInterceptor no longer works after upgrading from WebWork 2.2.4
> ----------------------------------------------------------------------------
>
> Key: WW-1593
> URL: https://issues.apache.org/struts/browse/WW-1593
> Project: Struts 2
> Issue Type: Bug
> Components: Interceptors
> Affects Versions: 2.0.1, 2.0.2
> Environment: Sun JDK 1.5; WinXP; WebLogic 9.2
> Reporter: Erik Pilz
> Assigned To: Don Brown
> Fix For: 2.0.3
>
>
> After upgrading from WebWork 2.2.4 to Struts 2.0.2-SNAPSHOT the actions that use the ExecuteAndWaitInterceptor no longer work. Looking at the changes to the interceptor it appears that the changes to add the "executeAfterValidationPass" property are causing the problem.
> To support this feature a new local variable "secondTime", which defaults to true, was added to the doIntercept() method. Later in the code are various checks to determine what result should be returned. The following is a condensed version of the if-else:
> if (!secondTime && bp != null && !bp.isDone()) {
> return WAIT;
> } else if (!secondTime && bp != null && bp.isDone()) {
> return bp.getResult();
> } else {
> return actionInvocation.invoke();
> }
> Looking at the code I can't see how the "secondTime" variable can ever be set to false except on the first iteration or if you're using the "executeAfterValidationPass" property.
> The workaround for now is to use the ExecuteAndWaitInterceptor that ships with WebWork 2.2.4.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira