You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/02/01 05:59:59 UTC
[GitHub] [kylin] woyumen4597 opened a new pull request #1086: KYLIN-4365 fix
RDBMS pushdown with clause bug
woyumen4597 opened a new pull request #1086: KYLIN-4365 fix RDBMS pushdown with clause bug
URL: https://github.com/apache/kylin/pull/1086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1086: KYLIN-4365 fix RDBMS
pushdown with clause bug
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1086: KYLIN-4365 fix RDBMS pushdown with clause bug
URL: https://github.com/apache/kylin/pull/1086#issuecomment-580999837
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=h1) Report
> Merging [#1086](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/26cf1f8ed217c96329d8dcbd8a00ef1d67023fca?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1086 +/- ##
============================================
+ Coverage 25.04% 25.05% +<.01%
+ Complexity 6224 6222 -2
============================================
Files 1440 1440
Lines 87821 87835 +14
Branches 12275 12279 +4
============================================
+ Hits 21999 22010 +11
- Misses 63664 63665 +1
- Partials 2158 2160 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/kylin/query/util/PushDownUtil.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25VdGlsLmphdmE=) | `80.48% <100%> (+4.01%)` | `4 <0> (ø)` | :arrow_down: |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=footer). Last update [26cf1f8...83537ca](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1086: KYLIN-4365 fix RDBMS
pushdown with clause bug
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1086: KYLIN-4365 fix RDBMS pushdown with clause bug
URL: https://github.com/apache/kylin/pull/1086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1086: KYLIN-4365 fix RDBMS
pushdown with clause bug
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1086: KYLIN-4365 fix RDBMS pushdown with clause bug
URL: https://github.com/apache/kylin/pull/1086#issuecomment-581000092
## Pull Request Test Coverage Report for [Build 5572](https://coveralls.io/builds/28468578)
* **17** of **17** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.01%**) to **27.521%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/28468578/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/28468578) |
| :-- | --: |
| Change from base [Build 5570](https://coveralls.io/builds/28468475): | 0.01% |
| Covered Lines: | 24173 |
| Relevant Lines: | 87835 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1086: KYLIN-4365 fix
RDBMS pushdown with clause bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1086: KYLIN-4365 fix RDBMS pushdown with clause bug
URL: https://github.com/apache/kylin/pull/1086#issuecomment-580999837
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=h1) Report
> Merging [#1086](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/26cf1f8ed217c96329d8dcbd8a00ef1d67023fca?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `86.36%`.
[](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1086 +/- ##
============================================
+ Coverage 25.04% 25.06% +0.01%
+ Complexity 6224 6223 -1
============================================
Files 1440 1440
Lines 87821 87845 +24
Branches 12275 12280 +5
============================================
+ Hits 21999 22019 +20
- Misses 63664 63666 +2
- Partials 2158 2160 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/kylin/query/util/PushDownUtil.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25VdGlsLmphdmE=) | `80.48% <100%> (+4.01%)` | `4 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `62.24% <40%> (-0.65%)` | `26 <2> (ø)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [.../org/apache/kylin/metadata/model/TableExtDesc.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVFeHREZXNjLmphdmE=) | `59.82% <0%> (+0.5%)` | `14% <0%> (ø)` | :arrow_down: |
| [...ava/org/apache/kylin/metadata/model/TableDesc.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVEZXNjLmphdmE=) | `47.64% <0%> (+0.77%)` | `27% <0%> (ø)` | :arrow_down: |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1086/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=footer). Last update [26cf1f8...10af481](https://codecov.io/gh/apache/kylin/pull/1086?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1086: KYLIN-4365 fix
RDBMS pushdown with clause bug
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1086: KYLIN-4365 fix RDBMS pushdown with clause bug
URL: https://github.com/apache/kylin/pull/1086#issuecomment-581000092
## Pull Request Test Coverage Report for [Build 5578](https://coveralls.io/builds/28478411)
* **20** of **22** **(90.91%)** changed or added relevant lines in **2** files are covered.
* **94** unchanged lines in **4** files lost coverage.
* Overall coverage increased (+**0.02%**) to **27.528%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/28478411/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L45) | 3 | 5 | 60.0%
<!-- | **Total:** | **20** | **22** | **90.91%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/28478411/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28478411/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
| [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableExtDesc.java](https://coveralls.io/builds/28478411/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableExtDesc.java#L78) | 23 | 62.39% |
| [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java](https://coveralls.io/builds/28478411/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableDesc.java#L67) | 65 | 53.53% |
<!-- | **Total:** | **94** | | -->
| Totals | [](https://coveralls.io/builds/28478411) |
| :-- | --: |
| Change from base [Build 5570](https://coveralls.io/builds/28468475): | 0.02% |
| Covered Lines: | 24182 |
| Relevant Lines: | 87845 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services