You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Craig Lewis (JIRA)" <ji...@apache.org> on 2011/02/02 02:11:29 UTC
[jira] Created: (AMQ-3172) Add support for Message Priority to
Stomp
Add support for Message Priority to Stomp
-----------------------------------------
Key: AMQ-3172
URL: https://issues.apache.org/jira/browse/AMQ-3172
Project: ActiveMQ
Issue Type: Improvement
Components: Transport
Affects Versions: 5.4.2
Reporter: Craig Lewis
Priority: Minor
Creating a Stomp message with a priority header has no effect. The messages are delivered in FIFO order, not priority order.
The Stomp transport (activemq-core/src/main/java/org/apache/activemq/transport/stomp/FrameTranslator.java) is calling msg.setJMSPriority(), but never calls producer.setPriority(). Because of this, messages claims to have a priority, but the messages are never actually re-ordered.
I believe a new unit test should be added to activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompTest.java. It should send 2 messages at different priorities, and verifies that they are re-ordered by ActiveMQ. I'll attach a unit test.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
SSL question
Posted by Adam Kaminiecki <ad...@dgt.com.pl>.
Hi,
Can anybody tell me what SSL type broker 5.4.2 and client (.net) 1.4.1
with NMS 1.5.0. use?
Regards,
Adam
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
[jira] Commented: (AMQ-3172) Add support for Message Priority to
Stomp
Posted by "Craig Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991770#comment-12991770 ]
Craig Lewis commented on AMQ-3172:
----------------------------------
Confirmed. Without the sleep, it fails approximately 50% of the time. After adding the sleep, it's passed 10 runs out of 10.
Thanks for the help.
> Add support for Message Priority to Stomp
> -----------------------------------------
>
> Key: AMQ-3172
> URL: https://issues.apache.org/jira/browse/AMQ-3172
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Transport
> Affects Versions: 5.4.2
> Reporter: Craig Lewis
> Priority: Minor
> Attachments: StompTest.java.patch
>
>
> Creating a Stomp message with a priority header has no effect. The messages are delivered in FIFO order, not priority order.
> The Stomp transport (activemq-core/src/main/java/org/apache/activemq/transport/stomp/FrameTranslator.java) is calling msg.setJMSPriority(), but never calls producer.setPriority(). Because of this, messages claims to have a priority, but the messages are never actually re-ordered.
> I believe a new unit test should be added to activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompTest.java. It should send 2 messages at different priorities, and verifies that they are re-ordered by ActiveMQ. I'll attach a unit test.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (AMQ-3172) Add support for Message Priority to Stomp
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish closed AMQ-3172.
-----------------------------
Resolution: Not A Problem
Working as designed, the message will be in order if both are allow to get to the queue before the consumer receive.
> Add support for Message Priority to Stomp
> -----------------------------------------
>
> Key: AMQ-3172
> URL: https://issues.apache.org/jira/browse/AMQ-3172
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Transport
> Affects Versions: 5.4.2
> Reporter: Craig Lewis
> Priority: Minor
> Attachments: StompTest.java.patch
>
>
> Creating a Stomp message with a priority header has no effect. The messages are delivered in FIFO order, not priority order.
> The Stomp transport (activemq-core/src/main/java/org/apache/activemq/transport/stomp/FrameTranslator.java) is calling msg.setJMSPriority(), but never calls producer.setPriority(). Because of this, messages claims to have a priority, but the messages are never actually re-ordered.
> I believe a new unit test should be added to activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompTest.java. It should send 2 messages at different priorities, and verifies that they are re-ordered by ActiveMQ. I'll attach a unit test.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (AMQ-3172) Add support for Message Priority to
Stomp
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991679#comment-12991679 ]
Timothy Bish commented on AMQ-3172:
-----------------------------------
The test given isn't quite right in that it produces to the Queue and then immediately creates a consumer and consumes a message. What can happen here is that the first message sent is dispatched and processed before the second message even makes it onto the Queue and so it appears to be out of order but in fact its not. You can see this by inserting a small sleep just after sending the second message, in this case both messages will be placed on the brokers queue and dispatched in the correct order. You could also place a small sleep after the consumer create so that both messages arrive in the consumers prefetch buffer and then see that they are dequeued in the correct order.
> Add support for Message Priority to Stomp
> -----------------------------------------
>
> Key: AMQ-3172
> URL: https://issues.apache.org/jira/browse/AMQ-3172
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Transport
> Affects Versions: 5.4.2
> Reporter: Craig Lewis
> Priority: Minor
> Attachments: StompTest.java.patch
>
>
> Creating a Stomp message with a priority header has no effect. The messages are delivered in FIFO order, not priority order.
> The Stomp transport (activemq-core/src/main/java/org/apache/activemq/transport/stomp/FrameTranslator.java) is calling msg.setJMSPriority(), but never calls producer.setPriority(). Because of this, messages claims to have a priority, but the messages are never actually re-ordered.
> I believe a new unit test should be added to activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompTest.java. It should send 2 messages at different priorities, and verifies that they are re-ordered by ActiveMQ. I'll attach a unit test.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (AMQ-3172) Add support for Message Priority to
Stomp
Posted by "Craig Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Lewis updated AMQ-3172:
-----------------------------
Attachment: StompTest.java.patch
A patch for activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompTest.java to unit test Stomp priority delivery.
> Add support for Message Priority to Stomp
> -----------------------------------------
>
> Key: AMQ-3172
> URL: https://issues.apache.org/jira/browse/AMQ-3172
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Transport
> Affects Versions: 5.4.2
> Reporter: Craig Lewis
> Priority: Minor
> Attachments: StompTest.java.patch
>
>
> Creating a Stomp message with a priority header has no effect. The messages are delivered in FIFO order, not priority order.
> The Stomp transport (activemq-core/src/main/java/org/apache/activemq/transport/stomp/FrameTranslator.java) is calling msg.setJMSPriority(), but never calls producer.setPriority(). Because of this, messages claims to have a priority, but the messages are never actually re-ordered.
> I believe a new unit test should be added to activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompTest.java. It should send 2 messages at different priorities, and verifies that they are re-ordered by ActiveMQ. I'll attach a unit test.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira