You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by CYJB <gi...@git.apache.org> on 2017/11/13 12:05:29 UTC

[GitHub] incubator-weex-site pull request #9: [WEEX-86][doc] Update web component's d...

GitHub user CYJB opened a pull request:

    https://github.com/apache/incubator-weex-site/pull/9

    [WEEX-86][doc] Update web component's document.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CYJB/incubator-weex-site master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex-site/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit f8330aba67f959810f92430b9e3e5dcdc919f9f8
Author: CYJB <f8...@126.com>
Date:   2017-11-13T12:04:21Z

    [WEEX-86][doc] Update web component's document.

----


---

[GitHub] incubator-weex-site pull request #9: [WEEX-86][doc] Update web component's d...

Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex-site/pull/9#discussion_r157476787
  
    --- Diff: source/references/components/web.md ---
    @@ -6,144 +6,103 @@ order: 8.16
     version: 2.1
     ---
     
    -# &lt;web&gt;
     <span class="weex-version">v0.5+</span>
     
    -Use web component to display any web content in the weex page. The `src`attribute is used to specify a special source. You also can use `webview` module to control some web operation such as goBack,goForward and reload. see [webview module](../modules/webview.html).For example,You can use web component and webview module to assemble a browser.
    +`<web>` is used to display web content that specified by `src` attribute in weex page. You also can use `webview` module to control WebView behavior such as goBack, goForward and reload, See [webview module](../modules/webview.html) for more infomation.
     
    -## Child Components
    +## Basic Usage
     
    -This component supports no child components.
    +> **Note:** `<web>` does not support any nested child components, and the style attributes of `width` and `height` must be specified, otherwise it won't work.
    --- End diff --
    
    Why  the style attributes must be specified, do you mean `src` ? 


---

[GitHub] incubator-weex-site pull request #9: [WEEX-86][doc] Update web component's d...

Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex-site/pull/9#discussion_r157476544
  
    --- Diff: source/references/components/web.md ---
    @@ -6,144 +6,103 @@ order: 8.16
     version: 2.1
     ---
     
    -# &lt;web&gt;
     <span class="weex-version">v0.5+</span>
     
    -Use web component to display any web content in the weex page. The `src`attribute is used to specify a special source. You also can use `webview` module to control some web operation such as goBack,goForward and reload. see [webview module](../modules/webview.html).For example,You can use web component and webview module to assemble a browser.
    +`<web>` is used to display web content that specified by `src` attribute in weex page. You also can use `webview` module to control WebView behavior such as goBack, goForward and reload, See [webview module](../modules/webview.html) for more infomation.
    --- End diff --
    
    information,  not 'infomation'


---

[GitHub] incubator-weex-site pull request #9: [WEEX-86][doc] Update web component's d...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex-site/pull/9


---