You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/20 16:10:26 UTC

[GitHub] [incubator-tvm] kice opened a new pull request #4750: Fix onnx import bugs

kice opened a new pull request #4750: Fix onnx import bugs
URL: https://github.com/apache/incubator-tvm/pull/4750
 
 
   Fix onnx attributes of string type incorrect handling
   Merge symmetric padding of Conv to symmetric form
   
   ref: https://github.com/apache/incubator-tvm/pull/4566#issuecomment-576125748

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] kice commented on issue #4750: Fix onnx import bugs

Posted by GitBox <gi...@apache.org>.
kice commented on issue #4750: Fix onnx import bugs
URL: https://github.com/apache/incubator-tvm/pull/4750#issuecomment-578278411
 
 
   @tqchen @jwfromm Please review the new changes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #4750: Fix onnx import bugs

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4750: Fix onnx import bugs
URL: https://github.com/apache/incubator-tvm/pull/4750
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4750: Fix onnx import bugs

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4750: Fix onnx import bugs
URL: https://github.com/apache/incubator-tvm/pull/4750#issuecomment-584868960
 
 
   Merge it for now to avoid staleness, and given that the code is properly reviewed. @kice @jwfromm would be great to add a followup PR to cover the case

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4750: Fix onnx import bugs

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4750: Fix onnx import bugs
URL: https://github.com/apache/incubator-tvm/pull/4750#issuecomment-578450716
 
 
   @kice  it would be great if you can add a testcase that covers this corner case

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4750: Fix onnx import bugs

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4750: Fix onnx import bugs
URL: https://github.com/apache/incubator-tvm/pull/4750#issuecomment-582718831
 
 
   ping @kice can you please add a few testcases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services