[GitHub] [zookeeper] surajj-naik commented on a change in pull request #1458: ZOOKEEPER-3938: java client: upgrade jline from 2.x to 3.x and adapt Completer to the new API.

[GitBox <gi...@apache.org>]

surajj-naik commented on a change in pull request #1458:
URL: https://github.com/apache/zookeeper/pull/1458#discussion_r491674272



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java
##########
@@ -282,45 +283,19 @@ public ZooKeeperMain(ZooKeeper zk) {
     void run() throws IOException, InterruptedException {
         if (cl.getCommand() == null) {
             System.out.println("Welcome to ZooKeeper!");
+            System.out.println("JLine support is enabled");
 
-            boolean jlinemissing = false;
-            // only use jline if it's in the classpath
-            try {
-                Class<?> consoleC = Class.forName("jline.console.ConsoleReader");

Review comment:
       Ya, my idea was to remove reflection as well since having jline as default seems like the way forward, given that it makes the zkCli very user friendly. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org