You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/01/08 19:44:20 UTC
svn commit: r1896844 - /xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/soap/FactoryFinder.java
Author: fanningpj
Date: Sat Jan 8 19:44:20 2022
New Revision: 1896844
URL: http://svn.apache.org/viewvc?rev=1896844&view=rev
Log:
sonar issues
Modified:
xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/soap/FactoryFinder.java
Modified: xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/soap/FactoryFinder.java
URL: http://svn.apache.org/viewvc/xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/soap/FactoryFinder.java?rev=1896844&r1=1896843&r2=1896844&view=diff
==============================================================================
--- xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/soap/FactoryFinder.java (original)
+++ xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/soap/FactoryFinder.java Sat Jan 8 19:44:20 2022
@@ -88,10 +88,10 @@ class FactoryFinder {
+ File.separator + "jaxm.properties";
File file = new File(propertiesFileName);
if (file.exists()) {
- FileInputStream fileInput = new FileInputStream(file);
Properties properties = new Properties();
- properties.load(fileInput);
- fileInput.close();
+ try (FileInputStream fileInput = new FileInputStream(file)) {
+ properties.load(fileInput);
+ }
String factoryClassName = properties.getProperty(factoryPropertyName);
return newInstance(factoryClassName);
}
@@ -103,9 +103,10 @@ class FactoryFinder {
try {
InputStream inputstream = getResource(factoryResource);
if (inputstream != null) {
- BufferedReader bufferedreader = new BufferedReader(new InputStreamReader(inputstream, StandardCharsets.UTF_8));
- String factoryClassName = bufferedreader.readLine();
- bufferedreader.close();
+ String factoryClassName;
+ try (BufferedReader bufferedreader = new BufferedReader(new InputStreamReader(inputstream, StandardCharsets.UTF_8))) {
+ factoryClassName = bufferedreader.readLine();
+ }
if ((factoryClassName != null) && !"".equals(factoryClassName)) {
return newInstance(factoryClassName);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org