You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/04/02 14:14:18 UTC

svn commit: r761261 - in /ofbiz/trunk: applications/content/webapp/content/cms/ applications/content/widget/layout/ applications/product/widget/catalog/ framework/example/widget/example/ framework/webtools/widget/ specialpurpose/ecommerce/webapp/ecomme...

Author: jleroux
Date: Thu Apr  2 12:14:18 2009
New Revision: 761261

URL: http://svn.apache.org/viewvc?rev=761261&view=rev
Log:
Securing URLs, link element in screens and menus : 26th set + tabs to 4 spaces

We continue to approach the end... But for some exceptions, more than the 2 I found before. I will write a compilation on dev ML at end

Modified:
    ofbiz/trunk/applications/content/webapp/content/cms/CMSForms.xml
    ofbiz/trunk/applications/content/widget/layout/LayoutScreens.xml
    ofbiz/trunk/applications/product/widget/catalog/PromoScreens.xml
    ofbiz/trunk/framework/example/widget/example/CommonScreens.xml
    ofbiz/trunk/framework/webtools/widget/Menus.xml
    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/forum/ForumForms.xml

Modified: ofbiz/trunk/applications/content/webapp/content/cms/CMSForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/webapp/content/cms/CMSForms.xml?rev=761261&r1=761260&r2=761261&view=diff
==============================================================================
--- ofbiz/trunk/applications/content/webapp/content/cms/CMSForms.xml (original)
+++ ofbiz/trunk/applications/content/webapp/content/cms/CMSForms.xml Thu Apr  2 12:14:18 2009
@@ -131,7 +131,9 @@
             <text size="24"/>
         </field>
         <field name="createTopic" title="${uiLabelMap.CommonEmptyHeader}"  position="4">
-            <hyperlink also-hidden="false" target="createTopic${pageName}?mode=restore" description="Create Topic"/>
+            <hyperlink also-hidden="false" target="createTopic${pageName}" description="Create Topic">
+                <parameter param-name="mode" value="restore"/>
+            </hyperlink>
         </field>
         -->
         <field name="submitButton" title="${uiLabelMap.CommonUpload}" widget-style="smallSubmit">

Modified: ofbiz/trunk/applications/content/widget/layout/LayoutScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/widget/layout/LayoutScreens.xml?rev=761261&r1=761260&r2=761261&view=diff
==============================================================================
--- ofbiz/trunk/applications/content/widget/layout/LayoutScreens.xml (original)
+++ ofbiz/trunk/applications/content/widget/layout/LayoutScreens.xml Thu Apr  2 12:14:18 2009
@@ -82,7 +82,10 @@
                                 <section>
                                     <widgets>    
                                         <container>
-                                            <link target="EditLayoutSubContent?mode=add&amp;contentIdTo=TEMPLATE_MASTER" text="${uiLabelMap.CommonCreateNew}" style="buttontext"/>
+                                            <link target="EditLayoutSubContent" text="${uiLabelMap.CommonCreateNew}" style="buttontext">
+                                                <parameter param-name="mode" value="add"/>
+                                                <parameter param-name="contentIdTo" value="TEMPLATE_MASTER"/>
+                                            </link>
                                         </container>
                                         <include-form name="listListLayout" location="component://content/webapp/content/layout/LayoutForms.xml"/>
                                     </widgets>

Modified: ofbiz/trunk/applications/product/widget/catalog/PromoScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/PromoScreens.xml?rev=761261&r1=761260&r2=761261&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/widget/catalog/PromoScreens.xml (original)
+++ ofbiz/trunk/applications/product/widget/catalog/PromoScreens.xml Thu Apr  2 12:14:18 2009
@@ -89,8 +89,12 @@
                             <container>
                                 <label style="label">${uiLabelMap.CommonView}</label>
                                 <link target="FindProductPromo" text="${uiLabelMap.CommonAll}" style="buttontext"/>
-                                <link target="FindProductPromo?userEntered=Y" text="${uiLabelMap.CommonUserEnteredOnly}" style="buttontext"/>
-                                <link target="FindProductPromo?userEntered=N" text="${uiLabelMap.ProductPromotionImported}" style="buttontext"/>
+                                <link target="FindProductPromo" text="${uiLabelMap.CommonUserEnteredOnly}" style="buttontext">
+                                    <parameter param-name="userEntered" value="Y"/>
+                                </link>
+                                <link target="FindProductPromo" text="${uiLabelMap.ProductPromotionImported}" style="buttontext">
+                                    <parameter param-name="userEntered" value="N"/>
+                                </link>
                             </container>
                             <container style="screenlet-body">
                                 <section>

Modified: ofbiz/trunk/framework/example/widget/example/CommonScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/example/widget/example/CommonScreens.xml?rev=761261&r1=761260&r2=761261&view=diff
==============================================================================
--- ofbiz/trunk/framework/example/widget/example/CommonScreens.xml (original)
+++ ofbiz/trunk/framework/example/widget/example/CommonScreens.xml Thu Apr  2 12:14:18 2009
@@ -101,7 +101,9 @@
                                             <link target="ExampleReportPdf" text="${uiLabelMap.CommonPdf}" style="buttontext">
                                                 <parameter param-name="exampleId" from-field="exampleId"/>
                                             </link>
-                                            <link target="help?topic=ExampleEditHelp" text="${uiLabelMap.CommonHelp}" style="buttontext" target-window="_blank"/>
+                                            <link target="help" text="${uiLabelMap.CommonHelp}" style="buttontext" target-window="_blank">
+                                                <parameter param-name="topic" value="ExampleEditHelp"/>
+                                            </link>
                                         </container>
                                     </widgets>
                                     <fail-widgets>

Modified: ofbiz/trunk/framework/webtools/widget/Menus.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/Menus.xml?rev=761261&r1=761260&r2=761261&view=diff
==============================================================================
--- ofbiz/trunk/framework/webtools/widget/Menus.xml (original)
+++ ofbiz/trunk/framework/webtools/widget/Menus.xml Thu Apr  2 12:14:18 2009
@@ -107,7 +107,9 @@
             <link target="entityref" target-window="_BLANK"/>
         </menu-item>
         <menu-item name="entityrefStatic" title="${uiLabelMap.WebtoolsEntityReference} - ${uiLabelMap.WebtoolsEntityReferenceStaticVersion}">
-            <link target="entityref?forstatic=true" target-window="_BLANK"/>
+            <link target="entityref" target-window="_BLANK">
+                <parameter param-name="forstatic" value="true"/>
+            </link>
         </menu-item>
         <menu-item name="entityrefReport" title="${uiLabelMap.WebtoolsEntityReferencePdf}">
             <link target="entityrefReport" target-window="_BLANK"/>

Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/forum/ForumForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/forum/ForumForms.xml?rev=761261&r1=761260&r2=761261&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/forum/ForumForms.xml (original)
+++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/forum/ForumForms.xml Thu Apr  2 12:14:18 2009
@@ -82,7 +82,9 @@
             <text size="24"/>
         </field>
         <field name="createTopic" title="${uiLabelMap.CommonEmptyHeader}"  position="4">
-            <hyperlink also-hidden="false" target="createTopic${pageName}?mode=restore" description="Create Topic"/>
+            <hyperlink also-hidden="false" target="createTopic${pageName}" description="Create Topic">
+                <parameter param-name="mode" value="restore"/>
+            </hyperlink>
         </field>
         -->
         <field name="submitButton" title="${uiLabelMap.CommonUpload}" widget-style="smallSubmit">
@@ -262,7 +264,9 @@
             <text size="24"/>
         </field>
         <field name="createTopic" title="${uiLabelMap.CommonEmptyHeader}"  position="4">
-            <hyperlink also-hidden="false" target="createTopic${pageName}?mode=restore" description="Create Topic"/>
+            <hyperlink also-hidden="false" target="createTopic${pageName}" description="Create Topic">
+                <parameter param-name="mode" value="restore"/>
+            </hyperlink>
         </field>
         -->
         <field name="submitButton" title="${uiLabelMap.CommonUpload}" widget-style="smallSubmit">