You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/11/10 20:50:52 UTC
[GitHub] [cassandra] maedhroz opened a new pull request #815: CASSANDRA-16237 split read-repair upgrade tests up to avoid metaspace errors
maedhroz opened a new pull request #815:
URL: https://github.com/apache/cassandra/pull/815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] adelapena commented on a change in pull request #815: CASSANDRA-16237 split read-repair upgrade tests up to avoid metaspace errors
Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #815:
URL: https://github.com/apache/cassandra/pull/815#discussion_r521459419
##########
File path: test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeReadRepairDeleteTest.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.upgrade;
+
+import org.junit.Test;
+
+import org.apache.cassandra.distributed.api.ConsistencyLevel;
+
+import static org.apache.cassandra.distributed.shared.AssertUtils.assertRows;
+import static org.apache.cassandra.distributed.shared.AssertUtils.row;
+
+public class MixedModeReadRepairDeleteTest extends UpgradeTestBase
Review comment:
We could add a comment about why we have split the tests. That could be a hint for someone trying to unify them, or extending any of them with more cases.
```suggestion
/**
* Test read repair after partial deletions when the cluster nodes are in different versions.
*
* This test and {@link MixedModeReadRepairWriteTest} are separated to avoid OOM errors on CI (see CASSANDRA-16237).
*/
public class MixedModeReadRepairDeleteTest extends UpgradeTestBase
```
##########
File path: test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeReadRepairWriteTest.java
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.upgrade;
+
+import org.junit.Test;
+
+import org.apache.cassandra.distributed.api.ConsistencyLevel;
+
+import static org.apache.cassandra.distributed.shared.AssertUtils.assertRows;
+import static org.apache.cassandra.distributed.shared.AssertUtils.row;
+
+/**
+ * Test read repair when the cluster nodes are in different versions
Review comment:
```suggestion
* Test read repair after partial writes when the cluster nodes are in different versions.
*
* This test and {@link MixedModeReadRepairDeleteTest} are separated to avoid OOM errors on CI (see CASSANDRA-16237).
```
##########
File path: test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java
##########
@@ -196,4 +196,14 @@ public TestCase nodesToUpgrade(int ... nodes)
}
}
+ protected TestCase allUpgrades(int nodes, int... toUpgrade)
Review comment:
Nice utility function. Maybe we could have a variant asking for a range of versions, like everything up to 3.x, that could be used in `mixedModeReadRepairCompactStorage`. Not saying that we should do it in this ticket, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #815: CASSANDRA-16237 split read-repair upgrade tests up to avoid metaspace errors
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #815:
URL: https://github.com/apache/cassandra/pull/815#discussion_r521557502
##########
File path: test/distributed/org/apache/cassandra/distributed/upgrade/ReadRepairCompactStorageUpgradeTest.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.upgrade;
+
+import org.junit.Test;
+
+import org.apache.cassandra.distributed.api.ConsistencyLevel;
+import org.apache.cassandra.distributed.shared.Versions;
+
+public class ReadRepairCompactStorageUpgradeTest extends UpgradeTestBase
+{
+ /**
+ * Tests {@code COMPACT STORAGE} behaviour with mixed replica versions.
+ * <p>
+ * See CASSANDRA-15363 for further details.
+ */
+ @Test
+ public void mixedModeReadRepairCompactStorage() throws Throwable
Review comment:
It looks like COMPACT STORAGE is partially coming back, so wondering if the author of that patch should extend this?
##########
File path: test/distributed/org/apache/cassandra/distributed/upgrade/ReadRepairCompactStorageUpgradeTest.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.upgrade;
+
+import org.junit.Test;
+
+import org.apache.cassandra.distributed.api.ConsistencyLevel;
+import org.apache.cassandra.distributed.shared.Versions;
+
+public class ReadRepairCompactStorageUpgradeTest extends UpgradeTestBase
+{
+ /**
+ * Tests {@code COMPACT STORAGE} behaviour with mixed replica versions.
+ * <p>
+ * See CASSANDRA-15363 for further details.
+ */
+ @Test
+ public void mixedModeReadRepairCompactStorage() throws Throwable
+ {
+ new TestCase()
+ .nodes(2)
+ .upgrade(Versions.Major.v22, Versions.Major.v30)
+ .upgrade(Versions.Major.v22, Versions.Major.v3X)
+ .upgrade(Versions.Major.v30, Versions.Major.v3X)
+ .setup((cluster) -> cluster.schemaChange(withKeyspace("CREATE TABLE %s.tbl" +
Review comment:
COMPACT STORAGE has different flavors, so thinking we should also test these other flavors as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #815: CASSANDRA-16237 split read-repair upgrade tests up to avoid metaspace errors
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #815:
URL: https://github.com/apache/cassandra/pull/815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org