You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/31 09:07:22 UTC

[GitHub] [arrow] sagnikc-dremio opened a new pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

sagnikc-dremio opened a new pull request #7872:
URL: https://github.com/apache/arrow/pull/7872


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sagnikc-dremio commented on a change in pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

Posted by GitBox <gi...@apache.org>.
sagnikc-dremio commented on a change in pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#discussion_r464353530



##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##########
@@ -101,4 +101,29 @@ TEST(TestArithmeticOps, TestDiv) {
   context.Reset();
 }
 
+TEST(TestArithmeticOps, TestBitwiseOps) {
+  // bitwise AND
+  EXPECT_EQ(bitwise_and_int32_int32(5245, 94553), 4185);

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#issuecomment-667026323


   https://issues.apache.org/jira/browse/ARROW-9607


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] praveenbingo closed pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

Posted by GitBox <gi...@apache.org>.
praveenbingo closed pull request #7872:
URL: https://github.com/apache/arrow/pull/7872


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on a change in pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#discussion_r464793815



##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##########
@@ -101,4 +101,31 @@ TEST(TestArithmeticOps, TestDiv) {
   context.Reset();
 }
 
+TEST(TestArithmeticOps, TestBitwiseOps) {
+  // bitwise AND
+  EXPECT_EQ(bitwise_and_int32_int32(0x147D, 0x17159), 0x1059);

Review comment:
       please make sure these are zero padded to the same width,




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on a change in pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#discussion_r464023290



##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##########
@@ -101,4 +101,29 @@ TEST(TestArithmeticOps, TestDiv) {
   context.Reset();
 }
 
+TEST(TestArithmeticOps, TestBitwiseOps) {
+  // bitwise AND
+  EXPECT_EQ(bitwise_and_int32_int32(5245, 94553), 4185);

Review comment:
       Using integer values for testing bitwise operations is hard to read and verify could you use hex values instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pprudhvi commented on a change in pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

Posted by GitBox <gi...@apache.org>.
pprudhvi commented on a change in pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#discussion_r466223016



##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc
##########
@@ -234,6 +234,37 @@ DIV_FLOAT(float64)
 
 #undef DIV_FLOAT
 
+#define BITWISE_AND(TYPE)                                                  \

Review comment:
       you could use existing BINARY_SYMMETRIC macro for AND, OR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sagnikc-dremio commented on a change in pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

Posted by GitBox <gi...@apache.org>.
sagnikc-dremio commented on a change in pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#discussion_r466306802



##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc
##########
@@ -234,6 +234,37 @@ DIV_FLOAT(float64)
 
 #undef DIV_FLOAT
 
+#define BITWISE_AND(TYPE)                                                  \

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org