[GitHub] [activemq] jgallimore commented on a change in pull request #636: Forward commit commands for local transactions as well as XA transact…

[GitBox <gi...@apache.org>]

jgallimore commented on a change in pull request #636:
URL: https://github.com/apache/activemq/pull/636#discussion_r600643368



##########
File path: activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/MessageDatabase.java
##########
@@ -2236,7 +2236,7 @@ private boolean shouldForward(JournalCommand<?> command) {
                 result = true;
             } else if (command instanceof KahaCommitCommand) {
                 KahaCommitCommand kahaCommitCommand = (KahaCommitCommand) command;
-                if (kahaCommitCommand.hasTransactionInfo() && kahaCommitCommand.getTransactionInfo().hasXaTransactionId()) {
+                if (kahaCommitCommand.hasTransactionInfo())  {

Review comment:
       That does make sense - I guess we wouldn't see a commit command without transaction info. I'll remove that check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org