[GitHub] [iceberg] nastra commented on a diff in pull request #5968: Core: Use explicit JSON Parser for namespace creation request

[GitBox <gi...@apache.org>]

nastra commented on code in PR #5968:
URL: https://github.com/apache/iceberg/pull/5968#discussion_r1003528420


##########
core/src/main/java/org/apache/iceberg/rest/requests/CreateNamespaceRequest.java:
##########
@@ -19,80 +19,24 @@
 package org.apache.iceberg.rest.requests;
 
 import java.util.Map;
-import java.util.Objects;
 import org.apache.iceberg.catalog.Namespace;
-import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
-import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
 import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-import org.apache.iceberg.relocated.com.google.common.collect.Maps;
 import org.apache.iceberg.rest.RESTRequest;
+import org.immutables.value.Value;
 
 /** A REST request to create a namespace, with an optional set of properties. */
-public class CreateNamespaceRequest implements RESTRequest {
+@Value.Immutable
+public interface CreateNamespaceRequest extends RESTRequest {

Review Comment:
   I've fixed the ABI issue by introducing a `NamespaceCreateRequest` and deprecating the `CreateNamespaceRequest`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org