You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/12/28 12:35:55 UTC
[GitHub] [incubator-linkis] wushengyeyouya opened a new pull request #1248: Optimize the flink EngineConn and enhance the operator capabilities of ECM module and EC module.
wushengyeyouya opened a new pull request #1248:
URL: https://github.com/apache/incubator-linkis/pull/1248
### What is the purpose of the change
Optimize the flink EngineConn and enhance the operator capabilities of ECM module and EC module.
### Brief change log
(for example:)
- Resolve the problem of fetching progress with no information.
- Resolve the problem of deploying flink application without yarn appId.
- Enhance the FlinkOnceJob, support to execute set, show grammar of flinkSQL.
- Enhance the FlinkOnceJobTest, add the support of using onceJob operators.
- Since both ECM and EC need Operator module, so the Operator module has been moved to linkis-manager-common.
- Add the capability of Operator to ECM, so LinkisManager can request to execute ECM Operators by RPC.
- Add the capability of fetch EC logs from ECM, now we can get all logs of all ECs whenever the EC is running or stopped.
- Optimize the architecture of LinkisManager, so linkis-computation-client can request LinkisManager to route operator request to ECM.
- Optimize the logic of EC creation, and fill in more EC information when EC is creating.
- Delete the EngineConnLogOperator in accessible-executor, since some errors will be throws when the EC is starting or stopped.
- Add the capability of executing Operators to ECM in linkis-computation-client.
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
- Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- Anything that affects deployment: (yes / no / don't know)
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1248: Optimize the flink EngineConn and enhance the operator capabilities of ECM module and EC module.
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1248:
URL: https://github.com/apache/incubator-linkis/pull/1248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] wushengyeyouya commented on a change in pull request #1248: Optimize the flink EngineConn and enhance the operator capabilities of ECM module and EC module.
Posted by GitBox <gi...@apache.org>.
wushengyeyouya commented on a change in pull request #1248:
URL: https://github.com/apache/incubator-linkis/pull/1248#discussion_r775905258
##########
File path: linkis-computation-governance/linkis-client/linkis-computation-client/src/main/scala/org/apache/linkis/computation/client/once/result/ECMOperateResult.scala
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.computation.client.once.result
+
+import org.apache.linkis.httpclient.dws.annotation.DWSHttpMessageResult
+
+/**
+ * Created by enjoyyin on 2021/12/18.
+ */
Review comment:
Thanks, it is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1248: Optimize the flink EngineConn and enhance the operator capabilities of ECM module and EC module.
Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1248:
URL: https://github.com/apache/incubator-linkis/pull/1248#discussion_r775889062
##########
File path: linkis-computation-governance/linkis-client/linkis-computation-client/src/main/scala/org/apache/linkis/computation/client/once/result/ECMOperateResult.scala
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.computation.client.once.result
+
+import org.apache.linkis.httpclient.dws.annotation.DWSHttpMessageResult
+
+/**
+ * Created by enjoyyin on 2021/12/18.
+ */
Review comment:
Author information should be removed
##########
File path: linkis-computation-governance/linkis-engineconn-manager/linkis-engineconn-manager-server/src/main/scala/org/apache/linkis/ecm/server/exception/ECMErrorCode.scala
##########
@@ -0,0 +1,26 @@
+/*
+ * Copyright 2019 WeBank
Review comment:
should use apache license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org