You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hawq.apache.org by wengyanqing <gi...@git.apache.org> on 2018/04/01 14:07:10 UTC

[GitHub] incubator-hawq pull request #1350: HAWQ-1600. Parquet table data vectorized ...

Github user wengyanqing commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1350#discussion_r178459027
  
    --- Diff: contrib/vexecutor/execVScan.c ---
    @@ -148,7 +181,10 @@ ExecVScan(ScanState *node, ExecScanAccessMtd accessMtd)
                      * Form a projection tuple, store it in the result tuple slot
                      * and return it.
                      */
    -                return ExecProject(projInfo, NULL);
    +                ((TupleBatch)projInfo->pi_slot->PRIVATE_tb)->nrows = ((TupleBatch)slot->PRIVATE_tb)->nrows;
    +                memcpy(((TupleBatch)projInfo->pi_slot->PRIVATE_tb)->skip,
    --- End diff --
    
    If possible, avoid memory copy during tuple batch processing.


---