You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2006/07/12 19:20:01 UTC
Re: svn commit: r20600 - trunk/tools/hook-scripts/mailer
blair@tigris.org wrote:
> Author: blair
> Date: Wed Jul 12 12:14:22 2006
> New Revision: 20600
>
> Modified:
> trunk/tools/hook-scripts/mailer/mailer.py
>
> Log:
> Allow the maps to also apply to the diff_add_url, diff_copy_url,
> diff_delete_url and diff_modify_url parameters.
>
> * tools/hook-scripts/mailer/mailer.py
> (DiffURLSelections.__init__):
> Take the mapping parameters as an additional argument and use it
> when getting the diff_add_url, diff_copy_url, diff_delete_url
> and diff_modify_url parameters.
> (Commit.generate_content):
> Pass the mapping parameters to the DiffURLSelections constructor.
What? No change to the sample conf-file to indicate this new feature?
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svn commit: r20600 - trunk/tools/hook-scripts/mailer
Posted by Blair Zajac <bl...@orcaware.com>.
C. Michael Pilato wrote:
> C. Michael Pilato wrote:
>> blair@tigris.org wrote:
>>
>>> Author: blair
>>> Date: Wed Jul 12 12:14:22 2006
>>> New Revision: 20600
>>>
>>> Modified:
>>> trunk/tools/hook-scripts/mailer/mailer.py
>>>
>>> Log:
>>> Allow the maps to also apply to the diff_add_url, diff_copy_url,
>>> diff_delete_url and diff_modify_url parameters.
>>>
>>> * tools/hook-scripts/mailer/mailer.py
>>> (DiffURLSelections.__init__):
>>> Take the mapping parameters as an additional argument and use it
>>> when getting the diff_add_url, diff_copy_url, diff_delete_url
>>> and diff_modify_url parameters.
>>> (Commit.generate_content):
>>> Pass the mapping parameters to the DiffURLSelections constructor.
>>
>> What? No change to the sample conf-file to indicate this new feature?
>
> Oh, I see from your STATUS addition that this was more of a bugfix than a
> feature, since apparently this kind of mapping would have been expected to
> work already, given a reading of the conf-file comments. Maybe point this
> out in your log message?
I've tweaked the commit message to reflect this.
Regards,
Blair
--
Blair Zajac, Ph.D.
<bl...@orcaware.com>
Subversion training, consulting and support
http://www.orcaware.com/svn/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r20600 - trunk/tools/hook-scripts/mailer
Posted by "C. Michael Pilato" <cm...@collab.net>.
C. Michael Pilato wrote:
> blair@tigris.org wrote:
>
>>Author: blair
>>Date: Wed Jul 12 12:14:22 2006
>>New Revision: 20600
>>
>>Modified:
>> trunk/tools/hook-scripts/mailer/mailer.py
>>
>>Log:
>>Allow the maps to also apply to the diff_add_url, diff_copy_url,
>>diff_delete_url and diff_modify_url parameters.
>>
>>* tools/hook-scripts/mailer/mailer.py
>> (DiffURLSelections.__init__):
>> Take the mapping parameters as an additional argument and use it
>> when getting the diff_add_url, diff_copy_url, diff_delete_url
>> and diff_modify_url parameters.
>> (Commit.generate_content):
>> Pass the mapping parameters to the DiffURLSelections constructor.
>
>
> What? No change to the sample conf-file to indicate this new feature?
Oh, I see from your STATUS addition that this was more of a bugfix than a
feature, since apparently this kind of mapping would have been expected to
work already, given a reading of the conf-file comments. Maybe point this
out in your log message?
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svn commit: r20600 - trunk/tools/hook-scripts/mailer
Posted by Blair Zajac <bl...@orcaware.com>.
C. Michael Pilato wrote:
> blair@tigris.org wrote:
>> Author: blair
>> Date: Wed Jul 12 12:14:22 2006
>> New Revision: 20600
>>
>> Modified:
>> trunk/tools/hook-scripts/mailer/mailer.py
>>
>> Log:
>> Allow the maps to also apply to the diff_add_url, diff_copy_url,
>> diff_delete_url and diff_modify_url parameters.
>>
>> * tools/hook-scripts/mailer/mailer.py
>> (DiffURLSelections.__init__):
>> Take the mapping parameters as an additional argument and use it
>> when getting the diff_add_url, diff_copy_url, diff_delete_url
>> and diff_modify_url parameters.
>> (Commit.generate_content):
>> Pass the mapping parameters to the DiffURLSelections constructor.
>
> What? No change to the sample conf-file to indicate this new feature?
The tools/hook-scripts/mailer/mailer.conf.example file already suggests that
this should work:
# This section can be used define rewrite mappings for option values. It
# is typically used for computing from/to addresses, but can actually be
# used to remap values for any option in this file.
Regards,
Blair
--
Blair Zajac, Ph.D.
<bl...@orcaware.com>
Subversion training, consulting and support
http://www.orcaware.com/svn/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org