[GitHub] arina-ielchiieva commented on a change in pull request #1560: DRILL-6877: NPE when starting Drill on Windows

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1560: DRILL-6877: NPE when starting Drill on Windows
URL: https://github.com/apache/drill/pull/1560#discussion_r238689068
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java
 ##########
 @@ -374,17 +374,22 @@ public void run () {
     }
 
     private void pollShutdown(Drillbit drillbit) throws IOException, InterruptedException {
-      final Path drillPidDirPath = FileSystems.getDefault().getPath(System.getenv("DRILL_PID_DIR"));
-      final String gracefulFileName = System.getenv("GRACEFUL_SIGFILE");
+      final String drillHome = System.getenv("DRILL_HOME");
+      final String gracefulFile = System.getenv("GRACEFUL_SIGFILE");
+      if (drillHome == null || gracefulFile == null) {
+        logger.warn("Cannot access graceful file. Graceful shutdown from command line will not be supported.");
+        return;
+      }
+      final Path drillHomePath = FileSystems.getDefault().getPath(drillHome);
 
 Review comment:
   Does this guarantee that local file system will be used? For example, on the cluster default file system might be distributed one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services