You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/15 22:20:31 UTC

[GitHub] [arrow-julia] visr opened a new pull request, #361: don't run tests that fail on Windows

visr opened a new pull request, #361:
URL: https://github.com/apache/arrow-julia/pull/361

   This is a bit crude, but there are currently many IOErrors on Windows, coming from calling `Arrow.Table(path::String)` where path is in a temp dir that gets cleaned up at the end of `mktemp`/`mktempdir`.
   
   ```julia
   mktempdir() do dir
       path = joinpath(dir, "test.arrow")
       Arrow.write(path, t)
       t2 = Arrow.Table(path)
   end
   ```
   
   One can avoid this by using
   
   ```julia
   open(path) do io
       Arrow.Table(io)
   end
   ```
   
   But then we're not testing the Mmap and String methods, so I'm simple disabling these tests on Windows. Related to #61, which perhaps should be reopened, to see if we can find a resolution.
   
   With this all tests pass on Windows except for the `resize!` issue mentioned in https://github.com/apache/arrow-julia/pull/357#issuecomment-1301943392.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-julia] quinnj merged pull request #361: don't run tests that fail on Windows

Posted by GitBox <gi...@apache.org>.
quinnj merged PR #361:
URL: https://github.com/apache/arrow-julia/pull/361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org