You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Willem Jiang (JIRA)" <ji...@apache.org> on 2011/09/09 07:13:08 UTC

[jira] [Created] (CXF-3796) Introduce an header to disable the handling the PartialResponse when the response code is 202

Introduce an header to disable the handling the PartialResponse when the response code is 202
---------------------------------------------------------------------------------------------

                 Key: CXF-3796
                 URL: https://issues.apache.org/jira/browse/CXF-3796
             Project: CXF
          Issue Type: Improvement
          Components: Transports
            Reporter: Willem Jiang
            Assignee: Willem Jiang
             Fix For: 2.4.3


The change of CXF-3788 breaks a test of camel-cxf which is using the MESSAGE data format to route the oneway request.
When the camel-cxf endpoint working in the MESSAGE data formate, it know nothing about the binding operation of the request and response, so it just treat it as two way request. The change of CXF-3788 just eat up the response, and camel route will wait for the response forever.

I'd like to introduce a message header to disable the handling the PartialResponse message in the HTTPConduit to fix the test failed of camel-cxf. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-3796) Introduce an header to disable the handling the PartialResponse when the response code is 202

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103576#comment-13103576 ] 

Aki Yoshida commented on CXF-3796:
----------------------------------

Hi Dan, Willem,
I updated the original ticket CXF-3788 with the patch to detect this condition and avoid blocking the call. Dan's new jaxws systests (version 1 and version2) that are supposed to simulate the problem reported in this ticket are activated and running fine. So, I think we do not need this extra parameter to configure the behavior. This needs to be verified.

As mentioned in my last comment in CXF-3788, we should be moving one of the constants from rt-ws-addr to api. Comments?
thanks.
regards, aki
 

> Introduce an header to disable the handling the PartialResponse when the response code is 202
> ---------------------------------------------------------------------------------------------
>
>                 Key: CXF-3796
>                 URL: https://issues.apache.org/jira/browse/CXF-3796
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.7, 2.4.3
>
>
> The change of CXF-3788 breaks a test of camel-cxf which is using the MESSAGE data format to route the oneway request.
> When the camel-cxf endpoint working in the MESSAGE data formate, it know nothing about the binding operation of the request and response, so it just treat it as two way request. The change of CXF-3788 just eat up the response, and camel route will wait for the response forever.
> I'd like to introduce a message header to disable the handling the PartialResponse message in the HTTPConduit to fix the test failed of camel-cxf. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CXF-3796) Introduce an header to disable the handling the PartialResponse when the response code is 202

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang resolved CXF-3796.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 2.3.7

Applied patch into trunk, 2.4.x and 2.3.x branch.

> Introduce an header to disable the handling the PartialResponse when the response code is 202
> ---------------------------------------------------------------------------------------------
>
>                 Key: CXF-3796
>                 URL: https://issues.apache.org/jira/browse/CXF-3796
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.7, 2.4.3
>
>
> The change of CXF-3788 breaks a test of camel-cxf which is using the MESSAGE data format to route the oneway request.
> When the camel-cxf endpoint working in the MESSAGE data formate, it know nothing about the binding operation of the request and response, so it just treat it as two way request. The change of CXF-3788 just eat up the response, and camel route will wait for the response forever.
> I'd like to introduce a message header to disable the handling the PartialResponse message in the HTTPConduit to fix the test failed of camel-cxf. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-3796) Introduce an header to disable the handling the PartialResponse when the response code is 202

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101546#comment-13101546 ] 

Daniel Kulp commented on CXF-3796:
----------------------------------


Aki,

I just added an @Ignored test to DispatchClientServerTest in systests/jaxws that you could look at to see the reason this is needed.   Basically, if using a Dispatch client in Message mode (likely PAYLOAD mode as well), and you just have a raw XML message but no WSDL to associate it with, there isn't a way to really determine if the method you are about to invoke with it is a one-way or a two way.   Thus, Camel just calls the equivalent of "invoke".   With the new behavior, this causes the client to hang.    The property Willem introduced allows Camel to set it to kind of retain the old behavior.  That said, I don't agree with that approach, but I need to think about it a bit.  Suggestions welcome.  :-)




> Introduce an header to disable the handling the PartialResponse when the response code is 202
> ---------------------------------------------------------------------------------------------
>
>                 Key: CXF-3796
>                 URL: https://issues.apache.org/jira/browse/CXF-3796
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.7, 2.4.3
>
>
> The change of CXF-3788 breaks a test of camel-cxf which is using the MESSAGE data format to route the oneway request.
> When the camel-cxf endpoint working in the MESSAGE data formate, it know nothing about the binding operation of the request and response, so it just treat it as two way request. The change of CXF-3788 just eat up the response, and camel route will wait for the response forever.
> I'd like to introduce a message header to disable the handling the PartialResponse message in the HTTPConduit to fix the test failed of camel-cxf. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-3796) Introduce an header to disable the handling the PartialResponse when the response code is 202

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102514#comment-13102514 ] 

Aki Yoshida commented on CXF-3796:
----------------------------------

Hi Dan,

I thought this change alone would work against cxf 2.4.x provider but might not work against the cxf trunk provider. Thanks for adding the test. I will look into it.
regards, aki

> Introduce an header to disable the handling the PartialResponse when the response code is 202
> ---------------------------------------------------------------------------------------------
>
>                 Key: CXF-3796
>                 URL: https://issues.apache.org/jira/browse/CXF-3796
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.7, 2.4.3
>
>
> The change of CXF-3788 breaks a test of camel-cxf which is using the MESSAGE data format to route the oneway request.
> When the camel-cxf endpoint working in the MESSAGE data formate, it know nothing about the binding operation of the request and response, so it just treat it as two way request. The change of CXF-3788 just eat up the response, and camel route will wait for the response forever.
> I'd like to introduce a message header to disable the handling the PartialResponse message in the HTTPConduit to fix the test failed of camel-cxf. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-3796) Introduce an header to disable the handling the PartialResponse when the response code is 202

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101228#comment-13101228 ] 

Aki Yoshida commented on CXF-3796:
----------------------------------

Hi Willem,
I am not sure whether this change works for cxf trunk. We needed to comply with the basic profile to return an HTTP response with no soap content for oneway calls in cxf trunk (for CXF-3768, CXF-366, and CXF-981).

Basically, the server endpoint will return an HTTP 202 with no content for oneway calls or those with the decoupled ws-a replyTo channel.

And when the response has no content and this handlingPartialResponse property is set to false, I think you will be getting some exception when you try to read the content later.

I am wondering if my assumption is right and if so, if there is another way of resolving this issue.

regards, aki 


> Introduce an header to disable the handling the PartialResponse when the response code is 202
> ---------------------------------------------------------------------------------------------
>
>                 Key: CXF-3796
>                 URL: https://issues.apache.org/jira/browse/CXF-3796
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.7, 2.4.3
>
>
> The change of CXF-3788 breaks a test of camel-cxf which is using the MESSAGE data format to route the oneway request.
> When the camel-cxf endpoint working in the MESSAGE data formate, it know nothing about the binding operation of the request and response, so it just treat it as two way request. The change of CXF-3788 just eat up the response, and camel route will wait for the response forever.
> I'd like to introduce a message header to disable the handling the PartialResponse message in the HTTPConduit to fix the test failed of camel-cxf. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira