You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 07:43:50 UTC

[GitHub] [pulsar] liangyuanpeng opened a new pull request, #17505: Delete unuse metrics of zk

liangyuanpeng opened a new pull request, #17505:
URL: https://github.com/apache/pulsar/pull/17505

   
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   
   
   *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
   
   
   
   ### Motivation
   
   clean up unuse code.
   
   passed CI on self repo CI.
   https://github.com/pulsar-sigs/pulsar/pull/2
   
   ### Modifications
   
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   
   This change is a trivial rework / code cleanup 
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
   - [x] `doc-not-needed` 
     
   - [ ] `doc` 
   
   - [ ] `doc-complete`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyuanpeng commented on pull request #17505: [cleanup][broker] Delete unuse metrics of zk_write_latency and zk_read_latency

Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #17505:
URL: https://github.com/apache/pulsar/pull/17505#issuecomment-1257156169

   @tisonkun Thanks for your update and merged master.
   
   
   This is just a minor code cleanup that can be merged easily and safely. Please someone review and merge,Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17505: [cleanup][broker] Delete unuse metrics of zk_write_latency and zk_read_latency

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17505:
URL: https://github.com/apache/pulsar/pull/17505#issuecomment-1253271843

   @liangyuanpeng I think you may merge the latest master to pass CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #17505: [cleanup][broker] Delete unuse metrics of zk_write_latency and zk_read_latency

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17505:
URL: https://github.com/apache/pulsar/pull/17505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17505: [cleanup][broker] Delete unuse metrics of zk_write_latency and zk_read_latency

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17505:
URL: https://github.com/apache/pulsar/pull/17505#issuecomment-1253271528

   @Shoothzj @merlimat shall we merge this PR now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shuimo03 commented on pull request #17505: [cleanup][broker] Delete unused metrics of zk_write_latency and zk_read_latency

Posted by "Shuimo03 (via GitHub)" <gi...@apache.org>.
Shuimo03 commented on PR #17505:
URL: https://github.com/apache/pulsar/pull/17505#issuecomment-1680213335

   Hi, I have question, Why is the pulsar_storage_write_latency metric an alternative to zk_write_latency?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyuanpeng commented on pull request #17505: [cleanup][broker] Delete unuse metrics of zk

Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #17505:
URL: https://github.com/apache/pulsar/pull/17505#issuecomment-1239341161

   > May I ask how can these metrics become unused? Is there any background for this change?
   
   
   These are legacy code that should be removed after [PIP45](https://github.com/apache/pulsar/wiki/PIP-45%3A-Pluggable-metadata-interface) is complete. The new metrics is  `pulsar_storage_ledger_write_latency`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyuanpeng commented on pull request #17505: [cleanup][broker] Delete unuse metrics of zk_write_latency and zk_read_latency

Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #17505:
URL: https://github.com/apache/pulsar/pull/17505#issuecomment-1257156622

   Just random ping someone. Thanks.
   
   @lhotari @hangc0276 @michaeljmarshall 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org