[jira] Commented: (TS-364) Remove LLONG from configure system

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869721#action_12869721 ] 

Leif Hedstrom commented on TS-364:
----------------------------------

I took a quick look, and I see what happened before. There are several areas in the code for Rec Integer configs that we downcast to an int32. For example:

librecords/I_RecCore.h:   _var = (int)REC_ConfigReadInteger(_config_var_name); \
librecords/I_RecCore.h:   _var = (int32)REC_ConfigReadInteger(_config_var_name); \
librecords/I_RecCore.h:   _var = (int32)REC_ConfigReadInteger(_config_var_name); \


There are several other places with the same problem, so part of this "cleanup" will also require to make all "RecInt" accessors and marshalling utilities to use int64 as well. My recommendation would be to fix that first, and commit (for testing), before we remove and "rename" the two configs that use LLONG.


> Remove LLONG from configure system
> ----------------------------------
>
>                 Key: TS-364
>                 URL: https://issues.apache.org/jira/browse/TS-364
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Cleanup
>            Reporter: Mladen Turk
>            Assignee: Mladen Turk
>            Priority: Minor
>             Fix For: 2.1.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Seems there was a general consensus to nuke the LLNOG from the config options
> and both unify and simplify the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.