You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@esme.apache.org by Richard Hirsch <hi...@gmail.com> on 2010/04/13 05:31:40 UTC

A few requests and few bugs

Hi,

A user found a few bugs and added a few requests for the next release:


** CRs:

* is it possible to get back the messageid when creating new messages?
(maybe within the "Location" header)

* is it possible to create an action that tests for a specific message id?


** Bugs

* the replyto element seems not to be filled when retrieving via the api

* GET /users/actions doesn't retrieve disabled actions?

* a PUT to /users/action/MESSAGEID results in a 403

Can we put the CRSs on the fast track. I've added everything to JIRA.

D.

Re: A few requests and few bugs

Posted by Ethan Jewett <es...@gmail.com>.
Just that there are "reply-to message IDs" and "conversation IDs". The
action could fire depending on either one.

Ethan

On Tue, Apr 13, 2010 at 9:48 AM, Richard Hirsch <hi...@gmail.com> wrote:
> On Tue, Apr 13, 2010 at 3:40 PM, Ethan Jewett <es...@gmail.com> wrote:
>
>> On Tue, Apr 13, 2010 at 9:13 AM, Richard Hirsch <hi...@gmail.com>
>> wrote:
>> >
>> > But we've used actions with tag-based tests in the same way.  For
>> example,
>> > in the akibot and 12sprints integrations.
>>
>> After reading the Jira ticket it makes more sense to me. I took this
>> as asking for an action that waits for a particular message and then
>> does something. But you are actually asking for an action that waits
>> for *replies* to particular messages and does something.
>>
>> What I'm wondering now is whether we want to test on the message being
>> replied to or the conversation associated with the message. What do
>> you think? I'm thinking that the conversation makes more sense,
>> because it will catch replies to replies, for example.
>>
>
> Do you mean: The action is fired when messages are added to the conversation
> based on the message with the message_id named in the action test.
>
>
>>
>> Depending on what the developers are trying to accomplish, there may
>> also be ways to use the API to do this.
>>
>> Ethan
>>
>

Re: A few requests and few bugs

Posted by Richard Hirsch <hi...@gmail.com>.
On Tue, Apr 13, 2010 at 3:40 PM, Ethan Jewett <es...@gmail.com> wrote:

> On Tue, Apr 13, 2010 at 9:13 AM, Richard Hirsch <hi...@gmail.com>
> wrote:
> >
> > But we've used actions with tag-based tests in the same way.  For
> example,
> > in the akibot and 12sprints integrations.
>
> After reading the Jira ticket it makes more sense to me. I took this
> as asking for an action that waits for a particular message and then
> does something. But you are actually asking for an action that waits
> for *replies* to particular messages and does something.
>
> What I'm wondering now is whether we want to test on the message being
> replied to or the conversation associated with the message. What do
> you think? I'm thinking that the conversation makes more sense,
> because it will catch replies to replies, for example.
>

Do you mean: The action is fired when messages are added to the conversation
based on the message with the message_id named in the action test.


>
> Depending on what the developers are trying to accomplish, there may
> also be ways to use the API to do this.
>
> Ethan
>

Re: A few requests and few bugs

Posted by Ethan Jewett <es...@gmail.com>.
On Tue, Apr 13, 2010 at 9:13 AM, Richard Hirsch <hi...@gmail.com> wrote:
>
> But we've used actions with tag-based tests in the same way.  For example,
> in the akibot and 12sprints integrations.

After reading the Jira ticket it makes more sense to me. I took this
as asking for an action that waits for a particular message and then
does something. But you are actually asking for an action that waits
for *replies* to particular messages and does something.

What I'm wondering now is whether we want to test on the message being
replied to or the conversation associated with the message. What do
you think? I'm thinking that the conversation makes more sense,
because it will catch replies to replies, for example.

Depending on what the developers are trying to accomplish, there may
also be ways to use the API to do this.

Ethan

Re: A few requests and few bugs

Posted by Richard Hirsch <hi...@gmail.com>.
On Tue, Apr 13, 2010 at 2:38 PM, Ethan Jewett <es...@gmail.com> wrote:

> Hi,
>
> Yes, we can definitely fast-track the ones related to the API. Glad
> someone is using it :-)
>
> A few questions below:
>
> On Mon, Apr 12, 2010 at 11:31 PM, Richard Hirsch <hi...@gmail.com>
> wrote:
>
> > * is it possible to get back the messageid when creating new messages?
> > (maybe within the "Location" header)
>
> Is this a request for the API? I assume so, and I think I should be
> able to add it to the message returned.
>

Yep


>
> > * is it possible to create an action that tests for a specific message
> id?
>
> I don't think we should do this. What is the use case that we are
> going for here? It seems very wasteful to have an action that hangs
> out waiting for a single message when we already know what the message
> is.
>

But we've used actions with tag-based tests in the same way.  For example,
in the akibot and 12sprints integrations.


>
> > * the replyto element seems not to be filled when retrieving via the api
>
> Hmmm, it should be. I will fix. What API method does this issue show
> up with? All the message APIs?
>
> > * GET /users/actions doesn't retrieve disabled actions?
>
> Will fix (user/actions actually)
>
> > * a PUT to /users/action/MESSAGEID results in a 403
>
> You can PUT to /user/actions/ACTIONID. I don't understand why we would
> expect messages to exist under an actions collection. What are they
> trying to do?
>
> Ethan
>

Re: A few requests and few bugs

Posted by Ethan Jewett <es...@gmail.com>.
Hi,

Yes, we can definitely fast-track the ones related to the API. Glad
someone is using it :-)

A few questions below:

On Mon, Apr 12, 2010 at 11:31 PM, Richard Hirsch <hi...@gmail.com> wrote:

> * is it possible to get back the messageid when creating new messages?
> (maybe within the "Location" header)

Is this a request for the API? I assume so, and I think I should be
able to add it to the message returned.

> * is it possible to create an action that tests for a specific message id?

I don't think we should do this. What is the use case that we are
going for here? It seems very wasteful to have an action that hangs
out waiting for a single message when we already know what the message
is.

> * the replyto element seems not to be filled when retrieving via the api

Hmmm, it should be. I will fix. What API method does this issue show
up with? All the message APIs?

> * GET /users/actions doesn't retrieve disabled actions?

Will fix (user/actions actually)

> * a PUT to /users/action/MESSAGEID results in a 403

You can PUT to /user/actions/ACTIONID. I don't understand why we would
expect messages to exist under an actions collection. What are they
trying to do?

Ethan