You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by si...@apache.org on 2011/10/25 10:29:19 UTC
svn commit: r1188561 - /commons/proper/ognl/trunk/pom.xml
Author: simonetripodi
Date: Tue Oct 25 08:29:18 2011
New Revision: 1188561
URL: http://svn.apache.org/viewvc?rev=1188561&view=rev
Log:
bechmarks active by default, they can be skipped using -DskipBenchmarks=true
Modified:
commons/proper/ognl/trunk/pom.xml
Modified: commons/proper/ognl/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/ognl/trunk/pom.xml?rev=1188561&r1=1188560&r2=1188561&view=diff
==============================================================================
--- commons/proper/ognl/trunk/pom.xml (original)
+++ commons/proper/ognl/trunk/pom.xml Tue Oct 25 08:29:18 2011
@@ -401,14 +401,11 @@ limitations under the License.
<profile>
<id>benchmarks</id>
<activation>
- <activeByDefault>false</activeByDefault>
- </activation>
- <!-- there are failures :/ activation>
<property>
<name>skipBenchmarks</name>
<value>!true</value>
</property>
- </activation -->
+ </activation>
<dependencies>
<dependency>
Re: svn commit: r1188561 - /commons/proper/ognl/trunk/pom.xml
Posted by Simone Tripodi <si...@apache.org>.
Hola Mau!
On Tue, Oct 25, 2011 at 10:47 AM, Maurizio Cucchiara
<mc...@apache.org> wrote:
> Personally I would have liked more if the benchmark was not active by default.
> This profile requires (hence increases) additional libraries (even if
> they are in test scope) which are useless (like old ognl library,
> parrot), unless you have specific reasons.
not an issue... or it is? If a committer needs to develop only the
core libraries, just turn the profile off.
The full build should execute benchmarks as well to be aware of (up|down)grades
> Also, if we choose to follow this way, I think we should configure
> Jenkins to automatic skip the benchmark stuff.
>
That is the same approach we already agreed and configured for the
site reports, sounds more than good to me!
Cheers, all the best,
Simo
Simo
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1188561 - /commons/proper/ognl/trunk/pom.xml
Posted by Maurizio Cucchiara <mc...@apache.org>.
Personally I would have liked more if the benchmark was not active by default.
This profile requires (hence increases) additional libraries (even if
they are in test scope) which are useless (like old ognl library,
parrot), unless you have specific reasons.
Also, if we choose to follow this way, I think we should configure
Jenkins to automatic skip the benchmark stuff.
WDYT?
Twitter :http://www.twitter.com/m_cucchiara
G+ :https://plus.google.com/107903711540963855921
Linkedin :http://www.linkedin.com/in/mauriziocucchiara
Maurizio Cucchiara
On 25 October 2011 10:29, <si...@apache.org> wrote:
> Author: simonetripodi
> Date: Tue Oct 25 08:29:18 2011
> New Revision: 1188561
>
> URL: http://svn.apache.org/viewvc?rev=1188561&view=rev
> Log:
> bechmarks active by default, they can be skipped using -DskipBenchmarks=true
>
> Modified:
> commons/proper/ognl/trunk/pom.xml
>
> Modified: commons/proper/ognl/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/ognl/trunk/pom.xml?rev=1188561&r1=1188560&r2=1188561&view=diff
> ==============================================================================
> --- commons/proper/ognl/trunk/pom.xml (original)
> +++ commons/proper/ognl/trunk/pom.xml Tue Oct 25 08:29:18 2011
> @@ -401,14 +401,11 @@ limitations under the License.
> <profile>
> <id>benchmarks</id>
> <activation>
> - <activeByDefault>false</activeByDefault>
> - </activation>
> - <!-- there are failures :/ activation>
> <property>
> <name>skipBenchmarks</name>
> <value>!true</value>
> </property>
> - </activation -->
> + </activation>
>
> <dependencies>
> <dependency>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org