You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/14 11:49:52 UTC
[GitHub] [airflow] ashb commented on a change in pull request #6315:
[AIRFLOW-5640] fix get_email_address_list types
ashb commented on a change in pull request #6315: [AIRFLOW-5640] fix get_email_address_list types
URL: https://github.com/apache/airflow/pull/6315#discussion_r334442859
##########
File path: airflow/models/baseoperator.py
##########
@@ -81,6 +81,15 @@ class derived from this one results in the creation of a task object,
:type task_id: str
:param owner: the owner of the task, using the unix username is recommended
:type owner: str
+ :param email: the 'to' email addresses used in email alerts (This can be a comma
+ or semicolon separated string)
+ :type email: iterable
Review comment:
```suggestion
:type email: str or list[str]
```
Sphinx syntax for types is different to mypy. Also A single string is supported. Although an a string is an iterable that isn't the intent here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services