You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/03 11:05:39 UTC
[GitHub] [airflow] ashb opened a new pull request #14577: Use libyaml C library when available.
ashb opened a new pull request #14577:
URL: https://github.com/apache/airflow/pull/14577
This makes loading local providers (`ProvidersManager.initialize_providers_manager()`) 1/3 quicker -- from 2s down from 3s on my local SSD.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14577: Use libyaml C library when available.
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14577:
URL: https://github.com/apache/airflow/pull/14577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14577: Use libyaml C library when available.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14577:
URL: https://github.com/apache/airflow/pull/14577#issuecomment-789680859
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #14577: Use libyaml C library when available.
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #14577:
URL: https://github.com/apache/airflow/pull/14577#issuecomment-789798312
Oh, To make new providers work with 2.0.0 I'm going to have to do
```
try:
import airflow.utils.yaml as yaml
except ImportError:
import yaml
```
Ugh.
(Judos to @potiuk for writing tests for this exact case!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14577: Use libyaml C library when available.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14577:
URL: https://github.com/apache/airflow/pull/14577#issuecomment-791322168
I think this shaves 3 minutes of the "WWW" tests - down to 8 minutes from 11 minutes, and about 6 minutes overall runtime (58mins for Py3.6 sqlite job, down to 52 -- still too high but this is an easy fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14577: Use libyaml C library when available.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14577:
URL: https://github.com/apache/airflow/pull/14577#issuecomment-789632427
Whoops wrong commit. I'm chaning this to use cyaml everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14577: Use libyaml C library when available.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14577:
URL: https://github.com/apache/airflow/pull/14577#issuecomment-789798312
Oh, To make new providers work with 2.0.0 I'm going to have to do
```
try:
import airflow.utils.yaml as yaml
except ImportError:
import yaml
```
Ugh.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org