You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/16 07:49:33 UTC

[GitHub] [airflow] 2ps opened a new pull request #21604: [ISSUE-21603] Reenabled passing cmd configuration

2ps opened a new pull request #21604:
URL: https://github.com/apache/airflow/pull/21604


   ## Problem?
   
   Not including `_cmd` configuration options broke configuration for
   `sql_alchemy_conn_cmd` and `fernet_key_cmd` which caused all tasks to
   fail with a mysterious sqlite error.
   
   ## Solution!
   
   Reenabled including `_cmd` configuration values when creating the
   temporary configuration used to run tasks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] 2ps commented on pull request #21604: [ISSUE-21603] Reenabled passing cmd configuration

Posted by GitBox <gi...@apache.org>.

2ps commented on pull request #21604:
URL: https://github.com/apache/airflow/pull/21604#issuecomment-1044784301


   @ashb  -- jsut as an FYI--we referenced an issue that we opened that would describe the problem that we were creating.  In the future, would you like us to include the issue description in both the PR and the issue, or just the issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #21604: [ISSUE-21603] Reenabled passing cmd configuration

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #21604:
URL: https://github.com/apache/airflow/pull/21604#issuecomment-1044879165


   I didn't notice at first the issue number in the title as GitHub didn't link it for me.
   
   If you are also going to open a PR, you can skip the issue and directly describe the problem in the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #21604: [ISSUE-21603] Reenabled passing cmd configuration

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #21604:
URL: https://github.com/apache/airflow/pull/21604#issuecomment-1042808518


   Please tell us how to reproduce this when it currently causing a problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb closed pull request #21604: [ISSUE-21603] Reenabled passing cmd configuration

Posted by GitBox <gi...@apache.org>.

ashb closed pull request #21604:
URL: https://github.com/apache/airflow/pull/21604


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #21604: [ISSUE-21603] Reenabled passing cmd configuration

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #21604:
URL: https://github.com/apache/airflow/pull/21604#issuecomment-1044729881


   Closing in favour of 21539


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21604: [ISSUE-21603] Reenabled passing cmd configuration

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #21604:
URL: https://github.com/apache/airflow/pull/21604#issuecomment-1041207236

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org