You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jonathan Perlow (Created) (JIRA)" <ji...@apache.org> on 2011/12/15 02:57:30 UTC
[jira] [Created] (HIVE-2655) Ability to define functions in HQL
Ability to define functions in HQL
----------------------------------
Key: HIVE-2655
URL: https://issues.apache.org/jira/browse/HIVE-2655
Project: Hive
Issue Type: New Feature
Components: SQL
Reporter: Jonathan Perlow
Ability to create functions in HQL as a substitute for creating them in Java.
Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2655:
------------------------------
Attachment: HIVE-2655.D915.3.patch
jonchang updated the revision "HIVE-2655 [jira] Ability to define functions in HQL".
Reviewers: JIRA, jsichi
Oops, for some reason an extra file made its way in there.
REVISION DETAIL
https://reviews.facebook.net/D915
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java
ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java
ql/src/test/queries/clientpositive/macro.q
ql/src/test/results/clientpositive/macro.q.out
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171756#comment-13171756 ]
Phabricator commented on HIVE-2655:
-----------------------------------
jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
This is a work in progress. Can't test right now because builtins are not loading for me in the test suite.
How does this general framework look though?
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2655:
------------------------------
Attachment: HIVE-2655.D915.4.patch
jonchang updated the revision "HIVE-2655 [jira] Ability to define functions in HQL".
Reviewers: JIRA, jsichi
handle stateful/deterministic
REVISION DETAIL
https://reviews.facebook.net/D915
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java
ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java
ql/src/test/queries/clientpositive/macro.q
ql/src/test/results/clientpositive/macro.q.out
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184713#comment-13184713 ]
Phabricator commented on HIVE-2655:
-----------------------------------
jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java:66-72 See above @ 1106 and 1113 of FunctionRegistry in this diff.
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184710#comment-13184710 ]
Phabricator commented on HIVE-2655:
-----------------------------------
ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java:66-72 I don't think this works for GenericUDF ?
FunctionRegistry looks like is only looking at annotations.
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2655:
------------------------------
Attachment: HIVE-2655.D915.1.patch
jonchang requested code review of "HIVE-2655 [jira] Ability to define functions in HQL".
Reviewers: JIRA
HIVE-2655
Ability to create functions in HQL as a substitute for creating them in Java.
Jonathan Chang requested I create this issue.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D915
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java
ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java
ql/src/test/queries/clientpositive/macro.q
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/1917/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183787#comment-13183787 ]
Phabricator commented on HIVE-2655:
-----------------------------------
ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
Looks good, see inline.
What do I have to do to have power to accept hive diffs? :)
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java:43 why stateful? (is that related to serialization?)
also it should probably be undeterministic since it can expres undeterministic function.
later you can make it check body to see if it is deterministic, and than do what is needed in initialize. But no need.
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265419#comment-13265419 ]
Phabricator commented on HIVE-2655:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
INLINE COMMENTS
ql/src/test/queries/clientpositive/macro.q:3 A couple more:
* Reference the same macro twice in the same query
* Reference two different macros in the same query
REVISION DETAIL
https://reviews.facebook.net/D915
BRANCH
macro
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2655) Ability to define functions in HQL
Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Chang updated HIVE-2655:
---------------------------------
Status: Patch Available (was: Open)
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183350#comment-13183350 ]
Phabricator commented on HIVE-2655:
-----------------------------------
jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
pingping
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184552#comment-13184552 ]
Phabricator commented on HIVE-2655:
-----------------------------------
jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
To accept diffs you have to become a committer. I think it's a pretty arduous process =/.
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2655) Ability to define functions in HQL
Posted by "Jonathan Chang (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Chang reassigned HIVE-2655:
------------------------------------
Assignee: Jonathan Chang
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172663#comment-13172663 ]
Phabricator commented on HIVE-2655:
-----------------------------------
ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
This is awesome!
And looks quite short. :)
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java:105 don't you need to at least register function here?
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265201#comment-13265201 ]
Phabricator commented on HIVE-2655:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2655 [jira] Ability to define functions in HQL".
INLINE COMMENTS
ql/src/test/queries/clientpositive/macro.q:3 The test coverage for this feature needs to be expanded.
What happens if the macro references a hiveconf or hivevar parameter?
Missing positive coverage for:
* Macro with zero input parameters
* Macro with two input parameters
* EXPLAIN output for a query using each variation of the above.
* EXPLAIN EXTENDED output for a query using each variation of the above.
Negative coverage for:
* macro body references an undefined input parameter
* input parameter not referenced in macro body
* macro that defines two input parameters with the same name
* Defining the same macro twice.
* Droping a macro that doesn't exist.
REVISION DETAIL
https://reviews.facebook.net/D915
BRANCH
macro
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2655:
------------------------------
Attachment: HIVE-2655.D915.2.patch
jonchang updated the revision "HIVE-2655 [jira] Ability to define functions in HQL".
Reviewers: JIRA, jsichi
Everything works now. Merry xmas!
REVISION DETAIL
https://reviews.facebook.net/D915
AFFECTED FILES
data/files/complex.seq
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java
ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java
ql/src/test/queries/clientpositive/macro.q
ql/src/test/results/clientpositive/macro.q.out
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172665#comment-13172665 ]
Phabricator commented on HIVE-2655:
-----------------------------------
jonchang has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java:105 Yes. Hence work in progress =).
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2655) Ability to define functions in HQL
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185329#comment-13185329 ]
Phabricator commented on HIVE-2655:
-----------------------------------
ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define functions in HQL".
Cool, in the long run it might be good to give that option to all GenericUDFs, but this is good for this diff.
Now you have to find somebody that can accept this :)
P.S. Can't wait to use this :)
REVISION DETAIL
https://reviews.facebook.net/D915
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira