[GitHub] [cordova-ios] dpogue commented on a diff in pull request #1320: feat: add listTarget api & revert original bin file location

["dpogue (via GitHub)" <gi...@apache.org>]

dpogue commented on code in PR #1320:
URL: https://github.com/apache/cordova-ios/pull/1320#discussion_r1182530717


##########
lib/run.js:
##########
@@ -229,16 +229,16 @@ function listEmulators () {
         });
 }
 
-module.exports.runListDevices = async function (options) {
-    const { options: cliArgs } = options;
+module.exports.runListDevices = async function (options = {}) {
+    const { options: cliArgs = {} } = options;

Review Comment:
   `const cliArgs = options.options ?? {};` seems way easier to read IMO, but I know that's not the "cool" way of doing things anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org