[jira] [Commented] (SLING-7074) RRD4J NPE on removing all "Data sources" from config

["Alex Deparvu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136963#comment-16136963 ] 

Alex Deparvu commented on SLING-7074:
-------------------------------------

In general I think the {{withDatasources}} should handle error case more gracefully. even the illegal values should be logged and ignored, now they are still kept in the config screen even though the RRD4JReporter class is in a weird state following the failed init (not sure what that is actually).

> RRD4J NPE on removing all "Data sources" from config
> ----------------------------------------------------
>
>                 Key: SLING-7074
>                 URL: https://issues.apache.org/jira/browse/SLING-7074
>             Project: Sling
>          Issue Type: Bug
>          Components: Commons
>            Reporter: Alex Deparvu
>            Priority: Minor
>             Fix For: Commons Metrics RRD4J 1.0.0
>
>
> Opened the config manager and deleted all entries
> {noformat}
>   *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: pid=org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter)] org.apache.sling.commons.metrics-rrd4j [org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter(3134)] The activate method has thrown an exception (java.lang.NullPointerException)
> java.lang.NullPointerException: null
>     at org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter$Builder.withDatasources(RRD4JReporter.java:91)
>     at org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter.activate(CodahaleMetricsReporter.java:143)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> fyi [~mreutegg]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)