You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Steve Hoffman <st...@goofy.net> on 2013/01/17 03:49:05 UTC
Review Request: Flume-1685: ExecSource shouldn't die if the channel is full
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8987/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Rather than kill the source outright when a channel fills, the channel should throw away the event (since there is nowhere to put it). A basic back-off mechanism is also implemented so retries get spaced out the longer the channel remains full up to a configurable limit.
Patches are attached to FLUME-1685 including a backport to the 1.2 branch (which I use with Cloudera's cdh3u5 distribution)
This addresses bug FLUME-1685.
https://issues.apache.org/jira/browse/FLUME-1685
Diffs
-----
Diff: https://reviews.apache.org/r/8987/diff/
Testing
-------
A unit test was created to test the full channel condition.
This patch has been running in our production environment for 2 months and has successfully recovered several times from full channel events.
Thanks,
Steve Hoffman
Re: Review Request: Flume-1685: ExecSource shouldn't die if the channel is
full
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On Jan. 17, 2013, 3:21 a.m., Brock Noland wrote:
> > Something is odd, here. I only see two buttons on the right "Review" and "Ship it". Normally there is a "view diff" button.
>
> Hari Shreedharan wrote:
> Same here, though I can see those buttons on other patches.
Going here: https://reviews.apache.org/r/8987/diff/ gives a 404. Seems like there is no review associated with the request. The repo is set to "Flume" and not "flume-git."
Steve: Can you submit a new request with the repo as flume-git? That will allow you to upload your diff when you select the repo.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8987/#review15442
-----------------------------------------------------------
On Jan. 17, 2013, 2:49 a.m., Steve Hoffman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8987/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 2:49 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Rather than kill the source outright when a channel fills, the channel should throw away the event (since there is nowhere to put it). A basic back-off mechanism is also implemented so retries get spaced out the longer the channel remains full up to a configurable limit.
>
> Patches are attached to FLUME-1685 including a backport to the 1.2 branch (which I use with Cloudera's cdh3u5 distribution)
>
>
> This addresses bug FLUME-1685.
> https://issues.apache.org/jira/browse/FLUME-1685
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/8987/diff/
>
>
> Testing
> -------
>
> A unit test was created to test the full channel condition.
> This patch has been running in our production environment for 2 months and has successfully recovered several times from full channel events.
>
>
> Thanks,
>
> Steve Hoffman
>
>
Re: Review Request: Flume-1685: ExecSource shouldn't die if the channel is
full
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On Jan. 17, 2013, 3:21 a.m., Brock Noland wrote:
> > Something is odd, here. I only see two buttons on the right "Review" and "Ship it". Normally there is a "view diff" button.
Same here, though I can see those buttons on other patches.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8987/#review15442
-----------------------------------------------------------
On Jan. 17, 2013, 2:49 a.m., Steve Hoffman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8987/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 2:49 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Rather than kill the source outright when a channel fills, the channel should throw away the event (since there is nowhere to put it). A basic back-off mechanism is also implemented so retries get spaced out the longer the channel remains full up to a configurable limit.
>
> Patches are attached to FLUME-1685 including a backport to the 1.2 branch (which I use with Cloudera's cdh3u5 distribution)
>
>
> This addresses bug FLUME-1685.
> https://issues.apache.org/jira/browse/FLUME-1685
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/8987/diff/
>
>
> Testing
> -------
>
> A unit test was created to test the full channel condition.
> This patch has been running in our production environment for 2 months and has successfully recovered several times from full channel events.
>
>
> Thanks,
>
> Steve Hoffman
>
>
Re: Review Request: Flume-1685: ExecSource shouldn't die if the channel is
full
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8987/#review15442
-----------------------------------------------------------
Something is odd, here. I only see two buttons on the right "Review" and "Ship it". Normally there is a "view diff" button.
- Brock Noland
On Jan. 17, 2013, 2:49 a.m., Steve Hoffman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8987/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 2:49 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Rather than kill the source outright when a channel fills, the channel should throw away the event (since there is nowhere to put it). A basic back-off mechanism is also implemented so retries get spaced out the longer the channel remains full up to a configurable limit.
>
> Patches are attached to FLUME-1685 including a backport to the 1.2 branch (which I use with Cloudera's cdh3u5 distribution)
>
>
> This addresses bug FLUME-1685.
> https://issues.apache.org/jira/browse/FLUME-1685
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/8987/diff/
>
>
> Testing
> -------
>
> A unit test was created to test the full channel condition.
> This patch has been running in our production environment for 2 months and has successfully recovered several times from full channel events.
>
>
> Thanks,
>
> Steve Hoffman
>
>