You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/04/11 21:19:20 UTC
Review Request 46045: Removing unused quota_check.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46045/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
This was used by the client updater, which is now defunct.
Diffs
-----
src/main/python/apache/aurora/client/api/quota_check.py a3252e571c34ef20438cfbbce6ceda2a50af0883
src/test/python/apache/aurora/client/api/test_quota_check.py 0b97334d3b5bf9bf2306248fbf7878be4c1a3995
Diff: https://reviews.apache.org/r/46045/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 46045: Removing unused quota_check.py
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46045/#review128215
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 11, 2016, 12:19 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46045/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 12:19 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was used by the client updater, which is now defunct.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py a3252e571c34ef20438cfbbce6ceda2a50af0883
> src/test/python/apache/aurora/client/api/test_quota_check.py 0b97334d3b5bf9bf2306248fbf7878be4c1a3995
>
> Diff: https://reviews.apache.org/r/46045/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 46045: Removing unused quota_check.py
Posted by Maxim Khutornenko <ma...@apache.org>.
> On April 11, 2016, 7:56 p.m., Aurora ReviewBot wrote:
> > Master (0dd096d) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [1m with temporary_dir() as checkpoint_root:[0m
> > [1m te = AuroraExecutor([0m
> > [1m> runner_provider=make_provider(checkpoint_root),[0m
> > [1m sandbox_provider=DefaultTestSandboxProvider())[0m
> >
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
> > [1m pex_location=thermos_runner_path(),[0m
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> >
> > build = True
> >
> > [1m def thermos_runner_path(build=True):[0m
> > [1m if not build:[0m
> > [1m return getattr(thermos_runner_path, 'value', None)[0m
> > [1m [0m
> > [1m if not hasattr(thermos_runner_path, 'value'):[0m
> > [1m pex_dir = safe_mkdtemp()[0m
> > [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
> > [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
> > [1m[31mE assert 1 == 0[0m
> > [1m[31mE + where 1 = <function call at 0x7fe041850938>(['./pants', '--pants-distdir=/tmp/user/10021/tmpB56S8e', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
> > [1m[31mE + where <function call at 0x7fe041850938> = subprocess.call[0m
> >
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
> > -------------- Captured stderr call --------------
> > Traceback (most recent call last):
> > File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", line 7, in <module>
> > from pants.bin.pants_exe import main
> > ImportError: No module named pants.bin.pants_exe
> > generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> > [1m[31m 16 failed, 631 passed, 6 skipped, 1 warnings, 8 error in 225.25 seconds [0m
> >
> > FAILURE
> >
> > [32m
> > Waiting for background workers to finish.[0m
> > 19:56:01 05:28 [complete][31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
@ReviewBot retry
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46045/#review128225
-----------------------------------------------------------
On April 11, 2016, 7:19 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46045/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 7:19 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was used by the client updater, which is now defunct.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py a3252e571c34ef20438cfbbce6ceda2a50af0883
> src/test/python/apache/aurora/client/api/test_quota_check.py 0b97334d3b5bf9bf2306248fbf7878be4c1a3995
>
> Diff: https://reviews.apache.org/r/46045/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 46045: Removing unused quota_check.py
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46045/#review128225
-----------------------------------------------------------
Master (0dd096d) is red with this patch.
./build-support/jenkins/build.sh
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7fe041850938>(['./pants', '--pants-distdir=/tmp/user/10021/tmpB56S8e', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7fe041850938> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 631 passed, 6 skipped, 1 warnings, 8 error in 225.25 seconds [0m
FAILURE
[32m
Waiting for background workers to finish.[0m
19:56:01 05:28 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 11, 2016, 7:19 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46045/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 7:19 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was used by the client updater, which is now defunct.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py a3252e571c34ef20438cfbbce6ceda2a50af0883
> src/test/python/apache/aurora/client/api/test_quota_check.py 0b97334d3b5bf9bf2306248fbf7878be4c1a3995
>
> Diff: https://reviews.apache.org/r/46045/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>