You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "luozenglin (via GitHub)" <gi...@apache.org> on 2023/05/04 06:55:51 UTC
[GitHub] [doris] luozenglin opened a new pull request, #19256: [enhancement](memory) MemCounter supports lock-free thread safety
luozenglin opened a new pull request, #19256:
URL: https://github.com/apache/doris/pull/19256
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1534630378
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19256:
URL: https://github.com/apache/doris/pull/19256#discussion_r1185917010
##########
be/src/runtime/memory/mem_tracker.h:
##########
@@ -64,32 +64,39 @@ class MemTracker {
MemCounter() : _current_value(0), _peak_value(0) {}
void add(int64_t delta) {
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto value = _current_value.fetch_add(delta, std::memory_order_relaxed) + delta;
+ update_peak(value);
}
void add_no_update_peak(int64_t delta) {
_current_value.fetch_add(delta, std::memory_order_relaxed);
}
bool try_add(int64_t delta, int64_t max) {
- if (UNLIKELY(_current_value.load(std::memory_order_relaxed) + delta > max))
- return false;
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto cur_val = _current_value.load(std::memory_order_relaxed);
+ auto new_val = 0;
+ do {
+ new_val = cur_val + delta;
+ if (UNLIKELY(new_val > max)) {
+ return false;
+ }
+ } while (UNLIKELY(!_current_value.compare_exchange_weak(cur_val, new_val,
+ std::memory_order_relaxed)));
+ update_peak(new_val);
return true;
}
+ void sub(int64_t delta) { _current_value.fetch_sub(delta, std::memory_order_relaxed); }
+
void set(int64_t v) {
_current_value.store(v, std::memory_order_relaxed);
- update_peak();
+ update_peak(v);
}
- void update_peak() {
- if (_current_value.load(std::memory_order_relaxed) >
- _peak_value.load(std::memory_order_relaxed)) {
- _peak_value.store(_current_value.load(std::memory_order_relaxed),
- std::memory_order_relaxed);
+ void update_peak(int64_t value) {
+ auto pre_value = _peak_value.load(std::memory_order_relaxed);
Review Comment:
if thread 2 enter the loop again, but the pre_value is still 3, so it will update failed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1534189554
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19256:
URL: https://github.com/apache/doris/pull/19256#discussion_r1185689368
##########
be/src/runtime/memory/mem_tracker.h:
##########
@@ -64,32 +64,39 @@ class MemTracker {
MemCounter() : _current_value(0), _peak_value(0) {}
void add(int64_t delta) {
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto value = _current_value.fetch_add(delta, std::memory_order_relaxed) + delta;
+ update_peak(value);
}
void add_no_update_peak(int64_t delta) {
_current_value.fetch_add(delta, std::memory_order_relaxed);
}
bool try_add(int64_t delta, int64_t max) {
- if (UNLIKELY(_current_value.load(std::memory_order_relaxed) + delta > max))
- return false;
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto cur_val = _current_value.load(std::memory_order_relaxed);
+ auto new_val = 0;
+ do {
+ new_val = cur_val + delta;
+ if (UNLIKELY(new_val > max)) {
+ return false;
+ }
+ } while (UNLIKELY(!_current_value.compare_exchange_weak(cur_val, new_val,
+ std::memory_order_relaxed)));
+ update_peak(new_val);
return true;
}
+ void sub(int64_t delta) { _current_value.fetch_sub(delta, std::memory_order_relaxed); }
+
void set(int64_t v) {
_current_value.store(v, std::memory_order_relaxed);
- update_peak();
+ update_peak(v);
}
- void update_peak() {
- if (_current_value.load(std::memory_order_relaxed) >
- _peak_value.load(std::memory_order_relaxed)) {
- _peak_value.store(_current_value.load(std::memory_order_relaxed),
- std::memory_order_relaxed);
+ void update_peak(int64_t value) {
+ auto pre_value = _peak_value.load(std::memory_order_relaxed);
Review Comment:
这个在多线程并发的时候，感觉也不对啊，比如
_peak_value = 3,
线程1： value = 10
线程2： value = 20
两个线程同时运行到line 97， 此时他们拿到的都是pre_value = 3， 此时加入线程1 先执行，那么_peak_value 被更新为10； 现成2 执行 line 98 会直接cas 失败，然后返回
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1539683581
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1534187023
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1537023988
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1537122047
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1537023640
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1539680020
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1534183761
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1534630428
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on code in PR #19256:
URL: https://github.com/apache/doris/pull/19256#discussion_r1185700375
##########
be/src/runtime/memory/mem_tracker.h:
##########
@@ -64,32 +64,39 @@ class MemTracker {
MemCounter() : _current_value(0), _peak_value(0) {}
void add(int64_t delta) {
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto value = _current_value.fetch_add(delta, std::memory_order_relaxed) + delta;
+ update_peak(value);
}
void add_no_update_peak(int64_t delta) {
_current_value.fetch_add(delta, std::memory_order_relaxed);
}
bool try_add(int64_t delta, int64_t max) {
- if (UNLIKELY(_current_value.load(std::memory_order_relaxed) + delta > max))
- return false;
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto cur_val = _current_value.load(std::memory_order_relaxed);
+ auto new_val = 0;
+ do {
+ new_val = cur_val + delta;
+ if (UNLIKELY(new_val > max)) {
+ return false;
+ }
+ } while (UNLIKELY(!_current_value.compare_exchange_weak(cur_val, new_val,
+ std::memory_order_relaxed)));
+ update_peak(new_val);
return true;
}
+ void sub(int64_t delta) { _current_value.fetch_sub(delta, std::memory_order_relaxed); }
+
void set(int64_t v) {
_current_value.store(v, std::memory_order_relaxed);
- update_peak();
+ update_peak(v);
}
- void update_peak() {
- if (_current_value.load(std::memory_order_relaxed) >
- _peak_value.load(std::memory_order_relaxed)) {
- _peak_value.store(_current_value.load(std::memory_order_relaxed),
- std::memory_order_relaxed);
+ void update_peak(int64_t value) {
+ auto pre_value = _peak_value.load(std::memory_order_relaxed);
Review Comment:
If pre_value and _peak_value do not match, `compare_exchange_weak` will returns false and updates _peak_value to pre_value, so thread 2 will update pre_value to 10 and enter the loop again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1537122643
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz merged pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz merged PR #19256:
URL: https://github.com/apache/doris/pull/19256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1535804415
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on code in PR #19256:
URL: https://github.com/apache/doris/pull/19256#discussion_r1185950624
##########
be/src/runtime/memory/mem_tracker.h:
##########
@@ -64,32 +64,39 @@ class MemTracker {
MemCounter() : _current_value(0), _peak_value(0) {}
void add(int64_t delta) {
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto value = _current_value.fetch_add(delta, std::memory_order_relaxed) + delta;
+ update_peak(value);
}
void add_no_update_peak(int64_t delta) {
_current_value.fetch_add(delta, std::memory_order_relaxed);
}
bool try_add(int64_t delta, int64_t max) {
- if (UNLIKELY(_current_value.load(std::memory_order_relaxed) + delta > max))
- return false;
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto cur_val = _current_value.load(std::memory_order_relaxed);
+ auto new_val = 0;
+ do {
+ new_val = cur_val + delta;
+ if (UNLIKELY(new_val > max)) {
+ return false;
+ }
+ } while (UNLIKELY(!_current_value.compare_exchange_weak(cur_val, new_val,
+ std::memory_order_relaxed)));
+ update_peak(new_val);
return true;
}
+ void sub(int64_t delta) { _current_value.fetch_sub(delta, std::memory_order_relaxed); }
+
void set(int64_t v) {
_current_value.store(v, std::memory_order_relaxed);
- update_peak();
+ update_peak(v);
}
- void update_peak() {
- if (_current_value.load(std::memory_order_relaxed) >
- _peak_value.load(std::memory_order_relaxed)) {
- _peak_value.store(_current_value.load(std::memory_order_relaxed),
- std::memory_order_relaxed);
+ void update_peak(int64_t value) {
+ auto pre_value = _peak_value.load(std::memory_order_relaxed);
Review Comment:
compare_exchange_weak updates pre_value if the comparison fails, so next enters the loop the pre_value will be 10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19256:
URL: https://github.com/apache/doris/pull/19256#issuecomment-1535806066
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on code in PR #19256:
URL: https://github.com/apache/doris/pull/19256#discussion_r1185700375
##########
be/src/runtime/memory/mem_tracker.h:
##########
@@ -64,32 +64,39 @@ class MemTracker {
MemCounter() : _current_value(0), _peak_value(0) {}
void add(int64_t delta) {
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto value = _current_value.fetch_add(delta, std::memory_order_relaxed) + delta;
+ update_peak(value);
}
void add_no_update_peak(int64_t delta) {
_current_value.fetch_add(delta, std::memory_order_relaxed);
}
bool try_add(int64_t delta, int64_t max) {
- if (UNLIKELY(_current_value.load(std::memory_order_relaxed) + delta > max))
- return false;
- _current_value.fetch_add(delta, std::memory_order_relaxed);
- update_peak();
+ auto cur_val = _current_value.load(std::memory_order_relaxed);
+ auto new_val = 0;
+ do {
+ new_val = cur_val + delta;
+ if (UNLIKELY(new_val > max)) {
+ return false;
+ }
+ } while (UNLIKELY(!_current_value.compare_exchange_weak(cur_val, new_val,
+ std::memory_order_relaxed)));
+ update_peak(new_val);
return true;
}
+ void sub(int64_t delta) { _current_value.fetch_sub(delta, std::memory_order_relaxed); }
+
void set(int64_t v) {
_current_value.store(v, std::memory_order_relaxed);
- update_peak();
+ update_peak(v);
}
- void update_peak() {
- if (_current_value.load(std::memory_order_relaxed) >
- _peak_value.load(std::memory_order_relaxed)) {
- _peak_value.store(_current_value.load(std::memory_order_relaxed),
- std::memory_order_relaxed);
+ void update_peak(int64_t value) {
+ auto pre_value = _peak_value.load(std::memory_order_relaxed);
Review Comment:
`compare_exchange_weak` will update pre_value on failure and thread 2 will update pre_value to 10 and enter the loop again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org