You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/28 10:30:24 UTC

[GitHub] [flink] fpompermaier commented on a change in pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

fpompermaier commented on a change in pull request #11906:
URL: https://github.com/apache/flink/pull/11906#discussion_r416505830



##########
File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/catalog/PostgresCatalog.java
##########
@@ -216,6 +234,49 @@ public CatalogBaseTable getTable(ObjectPath tablePath) throws TableNotExistExcep
 		}
 	}
 
+	private Map<String, List<String>>  getUniqueConstraints(DatabaseMetaData metaData, PostgresTablePath pgPath, Map.Entry<String, List<String>> pk) throws SQLException {

Review comment:
       Maybe it could worth to move getUniqueConstraints() and getPrimaryKey() into AbstractJDBCCatalog since they are of general validity




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org